Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileSerializerandAesFileSerializernow use a new base class implementation and have gained the ability tojournal(maintain durability through crashes and otherIOException, and ensure successful atomic write or complete rejection of changes), and cross-process isolation, preventing race condition that could be caused when multiple processes try to access the sameArrowDbfile.FileSerializerthis change may or may not break functionality and you should run tests to ensure everything still works as expected (With that said, my tests were not broken and did not require any adjusting).inttolong, this includesPendingChangesandRunningInstances.ArrowDbTransactionScopewas updated to allow nested transactions, and prevent corruption that can be caused by multiple transactions running concurrently on the sameArrowDbinstance. In addition, it was madepublicand also implements the regularIDisposableinterface to allow usage in synchronous context. However, it is still your responsibility to ensure the contexts match.Upsertand all its overloads will now reject (returnfalse) whenever the value to be upserted is anullreference type. This is to enforce a nonullpolicy that will simplify development by eliminatingnullchecks on retrieved values.Perf Improvements