Evidence Source: NFC Reader#380
Open
bettse wants to merge 2 commits intodustinrue:masterfrom
bettse:master
Open
Evidence Source: NFC Reader#380bettse wants to merge 2 commits intodustinrue:masterfrom bettse:master
bettse wants to merge 2 commits intodustinrue:masterfrom
bettse:master
Conversation
A consumer grade NFC reader from a defunct French company, Violet, who also made the Nabaztag and Karotz, early attempts at Internet of Things appliances.
|
Probably it would worth closing this one as it seems abandoned. If needed it could be revived anyway. |
Author
|
I never got any feedback on it, but I'm more than happy to respond to any feedback and rebase to bring it up to date. |
|
@dustinrue Please review these PRs or assign another contributor the necessary permissions to do so if you are too busy? |
Owner
|
@deed02392 There are no other trusted contributors on the project at this time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on software for an NFC reader off and on for a little over a year (https://github.com/bettse/janus) and the last time I was working on it, I began to realize that I was spending too much time trying to architect a platform for performing actions. When I picked up the project again, I started by looking for an application that already handled the 'output' (actions), so that I might add the reader as an 'input' (EvidenceSource). Although I'm not a regular user, I had played with ControlPlane in the past, so it came to mind. I saw the USBEvidenceSource and took it as evidence that supporting this USB device would be possible. I started porting my lower level device code into a plugin, and this PR is the result.
Since I'm not strongly familiar with the convention of the project, I'm guessing this will be far from in a state to actually merge. I welcome any feedback that may get it closer to such a state. I'm also aware that this also may be too esoteric to warrant inclusion in the mainline at all.
In terms of testing, this particular NFC reader is moderately difficult to acquire since the product line had been discontinued a year or two before company who produced it went out of business. I have an extra that I can ship if there is interest.