fix: replace MD5 with SHA-256 for avatar cache filenames#63
Open
0b0d3 wants to merge 2 commits intodvoraj75:mainfrom
Open
fix: replace MD5 with SHA-256 for avatar cache filenames#630b0d3 wants to merge 2 commits intodvoraj75:mainfrom
0b0d3 wants to merge 2 commits intodvoraj75:mainfrom
Conversation
asyncio.ensure_future is deprecated in favor of asyncio.create_task. Updated both indicator/app.py and indicator/client.py, plus the corresponding documentation. Closes dvoraj75#32 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace hashlib.md5 with hashlib.sha256 in _download_avatar and its test to remove the S324 lint suppression and avoid audit noise. Updated documentation to reflect the change. Closes dvoraj75#30 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hashlib.md5withhashlib.sha256innotifier._download_avatarnoqa: S324lint suppressiontest_notifier.pydocs/modules/notifier.mdCloses #30
Test plan
🤖 Generated with Claude Code