refactor: extract D-Bus constants to forgewatch.constants#66
Open
0b0d3 wants to merge 1 commit intodvoraj75:mainfrom
Open
refactor: extract D-Bus constants to forgewatch.constants#660b0d3 wants to merge 1 commit intodvoraj75:mainfrom
0b0d3 wants to merge 1 commit intodvoraj75:mainfrom
Conversation
Move BUS_NAME, OBJECT_PATH, and INTERFACE_NAME to a shared constants module to avoid drift between dbus_service.py and indicator/client.py. Closes dvoraj75#34 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forgewatch/constants.pywith shared D-Bus constants (BUS_NAME,OBJECT_PATH,INTERFACE_NAME)dbus_service.pyandindicator/client.pyto import from the shared moduleCloses #34
Test plan
🤖 Generated with Claude Code