[Release] HSTR 3.2.0 by dvorka · Pull Request #557 · dvorka/hstr

dvorka · 2026-01-28T06:54:29Z

This PR brings new HSTR release.

2026-02-06  Martin Dvorak  <martin.dvorak@mindforger.com>

  * Released v3.2.0 - Minor release bringing:
    - Configuration for TIOCSTI enforcement
    - Added SIGQUIT handling to cleanup terminal state on quit
    - Fixed buffer overflow (window resize) and missing Bash autocomplete configuration
    - Fixed undesired encapsulation of patterns with quotes in case they contain spaces
    - Updated changelog layout

…548 (#549)

…crashes when pressing Ctrl+/ - on wide terminals (>2048 characters), fixed CMDLINE_LNG caused a buffer overflow, corrupting memory and crashing the application when wgetch() tried to read input (#552) #508

… release

Copilot

Pull request overview

Release prep for HSTR v3.2.0, including runtime behavior changes around TIOCSTI enforcement/configuration, terminal cleanup improvements, and release/documentation/packaging updates.

Changes:

Add TIOCSTI-related configuration warning flow (with interactive prompt + suppression env var) and update shell integration snippets to use hstr -- ....
Handle SIGQUIT similarly to SIGINT for terminal cleanup; increase command-line buffer size to address overflow on resize.
Update docs, changelog/release metadata, CI workflow dependencies, and various packaging/build scripts.

Reviewed changes

Copilot reviewed 76 out of 78 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
test/test-utf8.sh	Copyright year bump for release.
test/test-keyb.sh	Copyright year bump for release.
test/test-history-generator.sh	Copyright year bump for release.
test/test-curses-keyb.sh	Copyright year bump for release.
test/test-bug-228.sh	Copyright year bump for release.
test/test-bug-176.sh	Copyright year bump for release.
test/test-bug-175.sh	Copyright year bump for release.
test/test-bug-163.sh	Copyright year bump for release.
test/test-bug-124.sh	Copyright year bump for release.
test/src/test_utf8.c	Copyright year bump for release.
test/src/test_keyb.c	Copyright year bump for release.
test/src/test_history_generator.c	Copyright year bump for release.
test/src/test_curses_keyb.c	Copyright year bump for release.
test/src/test.c	Copyright year bump for release.
test/hstr-unit-tests.pro	Copyright year bump for release.
src/radixsort.c	Copyright year bump for release.
src/main.c	Copyright year bump for release.
src/include/radixsort.h	Copyright year bump for release.
src/include/hstr_utils.h	Copyright year bump for release (also contains TIOCSTI behavior notes referenced by new logic).
src/include/hstr_regexp.h	Copyright year bump for release.
src/include/hstr_history.h	Copyright year bump for release.
src/include/hstr_favorites.h	Copyright year bump for release.
src/include/hstr_curses.h	Copyright year bump for release.
src/include/hstr_blacklist.h	Copyright year bump for release.
src/include/hstr.h	Add system includes needed by new select/isatty-based warning logic; copyright year bump.
src/include/hashset.h	Copyright year bump for release.
src/hstr_utils.c	Copyright year bump for release.
src/hstr_regexp.c	Copyright year bump for release.
src/hstr_history.c	Copyright year bump for release.
src/hstr_favorites.c	Copyright year bump for release.
src/hstr_curses.c	Copyright year bump for release.
src/hstr_blacklist.c	Copyright year bump for release.
src/hstr.c	v3.2.0 version string, larger cmdline buffer, SIGQUIT handling, TIOCSTI config warning flow, shell snippet updates.
src/hashset.c	Copyright year bump for release.
src/Makefile.am	Copyright header range update.
snap/snapcraft.yaml	Copyright year bump for release.
pad.xml	Update version/date/URLs/file size metadata for release.
man/hstr.1	Formatting cleanup + update no-TIOCSTI bash/zsh snippets to use `hstr -- ...`.
hstr.pro	Copyright year bump for release.
etc/bash-completion.d/hstr	Fix incorrect completion option (`--show-zsd-configuration` -> `--show-zsh-configuration`) and add bash-specific option.
doc/USER-DOCUMENTATION.md	Cleanup + replace `hh` examples with `hstr` for consistency.
configure.ac	Copyright year bump for release.
build/ubuntu/pbuilder-refresh-all-distros.sh	Copyright year bump for release.
build/ubuntu/pbuilder-add-new-distro.sh	Copyright year bump for release.
build/ubuntu/launchpad-make-all-releases.sh	Update launchpad release variables for 3.2 series.
build/ubuntu/launchpad-add-hstr-ppa.sh	Copyright year bump for release.
build/ubuntu/debian/copyright	Update year for packaging metadata.
build/travis-ci/.travis.yml	Copyright year bump for release.
build/test-units.sh	Copyright year bump for release.
build/test-set-env-utf8-history.sh	Copyright year bump for release.
build/test-set-env-monster-history.sh	Copyright year bump for release.
build/test-memleaks.sh	Adjust default scenarios/HISTFILE and valgrind invocation.
build/test-generate-unity-test-runner.sh	Copyright year bump for release.
build/test-gdb.sh	Copyright year bump for release.
build/test-clean.sh	Copyright year bump for release.
build/tarball/tarball-uninstall.sh	Copyright year bump for release.
build/tarball/tarball-build.sh	Update tarball version to 3.2.0.
build/tarball/tarball-automake.sh	Copyright year bump for release.
build/fedora/rpm-from-deb.sh	Copyright year bump for release.
build/debian/upload-to-mentors.sh	Copyright year bump for release.
build/debian/make-deb.sh	Update Debian packaging version strings to 3.2.0.
build/debian/debian/copyright	Update year for packaging metadata.
build/debian/aptly-add-deb.sh	Copyright year bump for release.
build/arch/update-pkgconfig-sha256-on-repo-change.sh	Copyright year bump for release.
build/anigif-rename.sh	Copyright year bump for release.
build/anigif-create.sh	Copyright year bump for release.
build/anigif-build.sh	Copyright year bump for release.
build/Makefile	Add a developer convenience Makefile for build/test/install workflows.
TIPS.md	New tips/tricks doc referenced from README.
SECURITY.md	Mark 3.2.0 as supported.
README.md	Add packages section and tips/troubleshooting links; reformat “In the News”.
PKGBUILD	Update Arch package version to 3.2 series.
INSTALLATION.md	Clarify importance of configuration for command insertion; link to issue.
Changelog	Add v3.2.0 entry and reformat older entries.
.gitignore	Ignore additional autotools artifacts and generated Makefiles.
.github/workflows/build_ubuntu.yml	Update runner and apt package list for newer Ubuntu.
.github/copilot-instructions.md	Add repo-specific Copilot guidance document.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

build/Makefile

.github/copilot-instructions.md

Copilot · 2026-01-28T06:59:57Z

src/hstr.c

+        char *tiocsti_env = getenv(HSTR_ENV_VAR_TIOCSTI);
+        char *suppress_warning = getenv(HSTR_ENV_VAR_SUPPRESS_WARNING);
+
+        // IF env var is not set, or is set to anything other than "n",
+        // THEN show warning unless suppression flag is set
+        if ((!tiocsti_env || strcmp(tiocsti_env, "n") != 0) && !suppress_warning) {
+            bool skip_check = false;


The suppression check uses only presence of HSTR_SUPPRESS_TIOCSTI_WARNING (non-NULL) to suppress the warning. This also suppresses when the variable is set to "0"/empty. Consider checking its value (e.g., == "1"/"true") so users can explicitly disable suppression.

Copilot · 2026-01-28T06:59:57Z

src/hstr.c

+        "HSTR cannot inject commands into your shell because:\n"
+        "  - Your Linux kernel >= 6.2.0 has TIOCSTI disabled\n"
+        "  - Your %s config is missing required HSTR function\n"
+        "To fix this, run:\n"


The warning text hard-codes "Your Linux kernel >= 6.2.0 has TIOCSTI disabled", but is_tiocsti_supported() returns false for non-Linux targets like MS_WSL/CYGWIN as well. Please adjust the message to accurately reflect the detected condition (e.g., "TIOCSTI is not available"), otherwise users on those platforms will see a misleading diagnosis.

Copilot · 2026-01-28T06:59:58Z

man/hstr.1

 function hstrnotiocsti {
-    { HSTR_OUT="$( { </dev/tty hstr -- ${READLINE_LINE}; } 2>&1 1>&3 3>&- )"; } 3>&1;
-    READLINE_LINE="$(hstr ${READLINE_LINE})"
+    { READLINE_LINE=\"$( { </dev/tty hstr -- ${READLINE_LINE}; } 2>&1 1>&3 3>&- )\"; } 3>&1;
    READLINE_POINT=${#READLINE_LINE}


In the Bash configuration snippet, the added backslashes around quotes (e.g., READLINE_LINE="$(...)") will appear literally in the rendered man page and can break copy/paste. Since this block is under .nf, the line should use normal shell quoting without the extra escapes.

build/test-memleaks.sh

augmentcode · 2026-01-28T07:01:50Z

🤖 Augment PR Summary

Summary: This PR prepares the HSTR 3.2.0 release, focusing on better behavior and guidance when TIOCSTI is unavailable and on improving documentation/packaging.

Changes:

Bumped version/release metadata to 3.2.0 across project files (Changelog, PKGBUILD, pad.xml, Debian/Ubuntu scripts).
Added a configuration-required warning/exit flow when TIOCSTI is disabled and shell integration isn’t configured; introduced HSTR_TIOCSTI and HSTR_SUPPRESS_TIOCSTI_WARNING.
Handled SIGQUIT in addition to SIGINT to help restore terminal state on quit.
Increased internal command-line buffer sizing and refreshed bash/zsh config snippets and bash-completion option names.
Updated GitHub Actions CI to run on ubuntu-latest and adjusted package dependencies for Ubuntu 24.04.
Improved user-facing docs (INSTALLATION/README, new TIPS.md) and added developer build helpers (build/Makefile) plus Valgrind test script refinements.

Technical Notes: The release targets kernels where TIOCSTI is restricted by default, encouraging users to add the appropriate shell function so HSTR can insert selected commands into the prompt.

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-01-28T07:01:51Z

src/hstr.c

+bool show_tiocsti_configuration_warning(void)
+{
+    // If stdin or stderr is not a TTY, don't prompt interactively to avoid invisible hangs
+    if (!isatty(STDIN_FILENO) || !isatty(STDERR_FILENO)) {


show_tiocsti_configuration_warning() returns false when STDERR isn’t a TTY, and the caller treats that as “exit and configure” (exits with HSTR_EXIT_CONFIG_REQUIRED). This can cause unexpected termination when users run with redirected stderr (e.g., exec 2>...); consider skipping the warning/exit path in that case instead of forcing exit.

Other Locations

src/hstr.c:1894

_{🤖 Was this useful? React with 👍 or 👎}

build/test-memleaks.sh

#488 (#558)

jakedane and others added 14 commits April 24, 2023 06:54

Update manpage and append -- to hstr calls

02306b8

Merge branch 'master' into dev-3.2.0

5add5b9

refactor(copyright): ♻️ 2025 > 2026

d74ca1d

fix(completion): 🐛 adding missing bash completion (#545)

fe04073

feat(tiocsti): ✨ adding interactive "TIOCSTI not configured" warning #…

b476bf6

…548 (#549)

build(makefile): vibe

d79ea5e

bug(views): fixing buffer overflow vulnerability in HSTR that caused …

4376a2c

…crashes when pressing Ctrl+/ - on wide terminals (>2048 characters), fixed CMDLINE_LNG caused a buffer overflow, corrupting memory and crashing the application when wgetch() tried to read input (#552) #508

build(version): 🏗️ updating version timestamp

25c776f

fix(signals): 🐛 adding handling of SIGQUIT sent with Ctrl-\ #508

66dacf3

doc(changelog): polishing changelog

d043726

test(memleaks):

9eddd2a

test(memleaks): improving valgrind command

7333a47

build(version): updating release timestamp

2864e1b

build: 🏗️ updating control files & polishing doc to prepare for 3.2.0…

a158564

… release

dvorka requested a review from Copilot January 28, 2026 06:54

dvorka self-assigned this Jan 28, 2026

dvorka added the 🚀 release label Jan 28, 2026

Copilot started reviewing on behalf of dvorka January 28, 2026 06:54 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

augmentcode bot reviewed Jan 28, 2026

View reviewed changes

dvorka added 9 commits January 28, 2026 08:34

build(ubuntu): 🏗️ improving Ubuntu Launchpad release script(s)

694a584

docs(install): 📝 updating installation instructions - TIOCSTI

7402d39

doc(web): adding website

6c5f186

doc(web): polishing footer

a1f5153

doc(readme): compacting packages to 3 columns

46b3b6e

doc(readme): compacting packages to 4 columns

6adc864

doc(readme): adding TUI

4a44a7a

docs(web): 📝 polishing website

e9178a2

refactor(build): ♻️ renaming stop motion scripts

d56bb1c

dvorka added 9 commits February 6, 2026 08:22

build(make): polishing Makefile

690dddf

Merge branch 'dev-3.2.0' of github.com:dvorka/hstr into dev-3.2.0

7eb8f1a

build(ubuntu): 👷 improving ubuntu release script

88b6f8d

fix(search): 🐛 fixing undesired " on insert of the patter w/ whitespace

465f8db

#488 (#558)

Merge branch 'dev-3.2.0' of github.com:dvorka/hstr into dev-3.2.0

be35555

build(ubuntu): 👷 fixing ubuntu launchpad script

cfdb03d

build(releng): 👷 improving release scripts for Ubuntu

4ecd398

docs(md): 📝 proofread / grammar fixes

7b1fbaa

docs(man): 📝 proofread / grammar fixes

e15f22d

dvorka mentioned this pull request Feb 6, 2026

[Review] incorporate 3.2.0 PR bot review comments #559

Open

dvorka merged commit a7635ce into master Feb 6, 2026
1 check passed

botantony mentioned this pull request Feb 7, 2026

hstr 3.2 Homebrew/homebrew-core#266298

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Release] HSTR 3.2.0#557

[Release] HSTR 3.2.0#557
dvorka merged 32 commits intomasterfrom
dev-3.2.0

dvorka commented Jan 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Uh oh!

augmentcode bot commented Jan 28, 2026

Uh oh!

augmentcode bot left a comment

Uh oh!

augmentcode bot Jan 28, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dvorka commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

augmentcode bot commented Jan 28, 2026

Uh oh!

augmentcode bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode bot Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dvorka commented Jan 28, 2026 •

edited

Loading