Skip to content

fix(search): 🐛 fixing undesired " on insert of the patter w/ whitespace#558

Merged
dvorka merged 10 commits intodev-3.2.0from
fix-20260202/garbage-2x-quotes
Feb 6, 2026
Merged

fix(search): 🐛 fixing undesired " on insert of the patter w/ whitespace#558
dvorka merged 10 commits intodev-3.2.0from
fix-20260202/garbage-2x-quotes

Conversation

@dvorka
Copy link
Owner

@dvorka dvorka commented Feb 2, 2026

@dvorka dvorka requested a review from Copilot February 2, 2026 21:03
@dvorka dvorka self-assigned this Feb 2, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where unwanted quote characters were being added to command line patterns containing whitespace during search pattern assembly.

Changes:

  • Removed automatic quoting of arguments containing whitespace
  • Adjusted buffer overflow check calculation from *2 to +1 to reflect removal of quotes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dvorka dvorka changed the title fix(search): fixing undesired " on insert of the patter w/ whitespace fix(search): 🐛 fixing undesired " on insert of the patter w/ whitespace Feb 2, 2026
@augmentcode
Copy link

augmentcode bot commented Feb 2, 2026

🤖 Augment PR Summary

Summary: Stops adding automatic double-quotes when assembling the initial search pattern from command-line args, preventing unwanted " characters for whitespace-containing patterns.

Changes: Simplifies the hstr_assemble_cmdline_pattern() length calculation since extra quotes are no longer appended.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@dvorka dvorka requested a review from Copilot February 2, 2026 21:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dvorka and others added 2 commits February 2, 2026 22:12
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dvorka dvorka requested a review from Copilot February 2, 2026 21:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dvorka dvorka requested a review from Copilot February 2, 2026 22:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dvorka dvorka linked an issue Feb 6, 2026 that may be closed by this pull request
@dvorka dvorka merged commit 465f8db into dev-3.2.0 Feb 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected double quote

2 participants