Open
Conversation
- add test case for locale 'de' to FormatterFactoryTest - use short array syntax - add type hints for parameters in tests - add return type hints in tests
- add constant visibility and type - fix code style (DdateHolydayTest) - use shorter type cast keywords
- remove class comments that convey no additional information - make sure package name is EmperorNortonCommands\lib\Ddate for all DDate internal classes
dweichert
force-pushed
the
dev/refactoring-and-improvement
branch
from
215c13f to
b9e87ff
Compare
- class XDay provides public API for getting days until X-Day from DateTimeInterface - class DiscordianDate provides public API for getting Discordian Date from DateTimeInterface
dweichert
force-pushed
the
dev/refactoring-and-improvement
branch
from
b9e87ff to
1c0fce3
Compare
- use Enum for locale parameter - array short syntax
dweichert
force-pushed
the
dev/refactoring-and-improvement
branch
from
1c0fce3 to
4576541
Compare
- create DateTimeImmutable via factory - add type hint for public method
- rename to method to create instance - make method to create instance static
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General modernization of the code base using PHP syntax introduced after PHP 5.3.
Fixes:
#58 Refactor tests
#59 Add annotations for internal and api classes