Implement attributes interface to Location superclass #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not exist, otherwise raises an error
…and the file was already present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements attribute
getandsetfunctions to theLocationclass and its derived types.Unlike in HDF5, attributes are written in an "Attributes" subgroup inside the location where we call
getandset... this is because HDF5 wants you to specify the parent location of the actual location that will contain the attribute. That would require keeping track of the location hierarchy and making sure the parent location is open when trying to write or read an attribute with a location.That's cumbersome overhead to manage and against the minimalist design of ClassyHDF, which requires that no assumptions about what other locations are open are necessary.