Skip to content

Support wildcard searching and batch uninstall#4

Open
ahdung wants to merge 2 commits intodwmkerr:masterfrom
ahdung:master
Open

Support wildcard searching and batch uninstall#4
ahdung wants to merge 2 commits intodwmkerr:masterfrom
ahdung:master

Conversation

@ahdung
Copy link
Copy Markdown

@ahdung ahdung commented Aug 11, 2021

No description provided.

@ahdung
Copy link
Copy Markdown
Author

ahdung commented Aug 11, 2021

#2 #3

Copy link
Copy Markdown
Owner

@dwmkerr dwmkerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I'm happy to merge it in when the TODOs are working, do you need any help with this? I'm a bit slammed but might be able to find some time.


MessageBox.Show(msg, "Uninstall");

//todo not work
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking does this still not work, would you like me to take a look at it?

if (ProcessUninstall(model, out var errorMsg))
{
// Remove the assembly from the vm.
ViewModel.Assemblies.Remove(model); //todo not work
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this not work as well?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's not work on my environment, Windows Server 2008 R2. it's a little issue, not important, I just record it, you know everyone is busy, I understand. Have a nice day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants