Support wildcard searching and batch uninstall#4
Open
ahdung wants to merge 2 commits intodwmkerr:masterfrom
Open
Support wildcard searching and batch uninstall#4ahdung wants to merge 2 commits intodwmkerr:masterfrom
ahdung wants to merge 2 commits intodwmkerr:masterfrom
Conversation
Add batch uninstall support.
Author
dwmkerr
requested changes
Aug 21, 2021
Owner
dwmkerr
left a comment
There was a problem hiding this comment.
Thanks for this! I'm happy to merge it in when the TODOs are working, do you need any help with this? I'm a bit slammed but might be able to find some time.
|
|
||
| MessageBox.Show(msg, "Uninstall"); | ||
|
|
||
| //todo not work |
Owner
There was a problem hiding this comment.
Just checking does this still not work, would you like me to take a look at it?
| if (ProcessUninstall(model, out var errorMsg)) | ||
| { | ||
| // Remove the assembly from the vm. | ||
| ViewModel.Assemblies.Remove(model); //todo not work |
Author
There was a problem hiding this comment.
Yes, it's not work on my environment, Windows Server 2008 R2. it's a little issue, not important, I just record it, you know everyone is busy, I understand. Have a nice day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.