Open
Conversation
…ricTransformation
…ns class to own file.
Owner
|
Happy to look over this again! I think it might make sense to try and create a new PR which only has the Bounding Volume code for now, as this is now an old PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Dave!
I like to show you my new branch "BoundingVolumesForAll". It is not targeted to the next release, rather I like to discuss the bounding volumes with you. I had the problem, that there are no bounding volumes for some objects (e.g. disk and teapot). So I implemented them. Further I saw the problem for polygon. We need to recalc the bounding volume based on changing vertices. I suggest some solutions in code comments using TODOs. Maybe you think it is worth enough to talk about or to use my branch somehow. Please feel free! :) Feedback would be great!