Skip to content

Conversation

@jakehobbs
Copy link
Member

No description provided.

@jakehobbs jakehobbs changed the title [NOT READY, WIP] react attendance page (take 2) [NOT READY, WIP] react attendance page Jan 2, 2026
@jakehobbs jakehobbs changed the title [NOT READY, WIP] react attendance page [NOT READY, WIP] react attendance pages Jan 2, 2026
@jakehobbs jakehobbs changed the title [NOT READY, WIP] react attendance pages feat: react attendance pages Jan 3, 2026
@jakehobbs jakehobbs force-pushed the jake/react-attendance-2 branch from 0368920 to f4244e9 Compare January 3, 2026 05:58
@jakehobbs jakehobbs force-pushed the jake/react-attendance-2 branch from c877be0 to 256d8d3 Compare January 3, 2026 06:10
@jakehobbs jakehobbs marked this pull request as ready for review January 3, 2026 06:10
@jakehobbs jakehobbs requested a review from alexsapps as a code owner January 3, 2026 06:10
@jakehobbs jakehobbs requested a review from mdzirbel January 3, 2026 06:13
@jakehobbs jakehobbs requested a review from alexsapps January 11, 2026 04:38
alexsapps
alexsapps previously approved these changes Jan 11, 2026
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this file be moved to event/new/page.tsx, to make room for a future event/page.tsx that lists all the events?

and should /event be renamed to /events for consistency with /users? cursory google search says plural is preferred

sorry just noticed this now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i was thinking that /event/list would be for the event list. no strong feelings, but will revisit later.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok sounds good to revisit later. just for the record my reasoning was it's easier to let users change the url themselves, at least to go up, e.g. if they see /events/218 or /events/add they can remove /218 or /add to go up a level in the navigation. i think of the list page as the highest level in that navigation hierarchy because it will usually provide all the other links.

@jakehobbs jakehobbs merged commit 13106bf into main Jan 20, 2026
1 check passed
@jakehobbs jakehobbs deleted the jake/react-attendance-2 branch January 20, 2026 01:43
@alexsapps
Copy link
Collaborator

alexsapps commented Jan 20, 2026

i just tried this out in prod, and i noticed some changes don't seem to save.

to reproduce:

  1. open an existing event
  2. remove someone, hit save
  3. add same person back, hit save
    result: their name disappears again / they do not get added back

similarly:

  1. open an existing event
  2. add someone, hit save
  3. remove the person you just added, hit save
    result: they do not get removed / their name reappears

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants