-
Notifications
You must be signed in to change notification settings - Fork 8
feat: react attendance pages #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0368920 to
f4244e9
Compare
c877be0 to
256d8d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this file be moved to event/new/page.tsx, to make room for a future event/page.tsx that lists all the events?
and should /event be renamed to /events for consistency with /users? cursory google search says plural is preferred
sorry just noticed this now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i was thinking that /event/list would be for the event list. no strong feelings, but will revisit later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok sounds good to revisit later. just for the record my reasoning was it's easier to let users change the url themselves, at least to go up, e.g. if they see /events/218 or /events/add they can remove /218 or /add to go up a level in the navigation. i think of the list page as the highest level in that navigation hierarchy because it will usually provide all the other links.
|
i just tried this out in prod, and i noticed some changes don't seem to save. to reproduce:
similarly:
|
No description provided.