Skip to content

Chore/update ci actions#16

Merged
akberc merged 4 commits intomainfrom
chore/update-ci-actions
Jan 6, 2026
Merged

Chore/update ci actions#16
akberc merged 4 commits intomainfrom
chore/update-ci-actions

Conversation

@akberc
Copy link
Member

@akberc akberc commented Jan 6, 2026

Important

Update CI actions, refactor GmailViewerCdkStack for improved infrastructure setup, and update dependencies in package.json.

  • CI/CD:
    • Update actions/checkout to v6 and actions/setup-node to v6 in .github/workflows/ci.yml.
    • Remove version check and publish steps for npm, replace with GitHub Packages publish step.
  • Infrastructure:
    • Refactor GmailViewerCdkStack in gmail-viewer-cdk-stack.ts to use L2 constructs for security groups, log groups, ECS cluster, and more.
    • Add publicSubnets support and refactor VPC setup logic.
    • Use secretsmanager.Secret for managing secrets instead of SSM parameters.
    • Update IAM roles and policies for task execution and build roles.
  • Dependencies:
    • Add @aws-sdk/client-s3, @aws-sdk/client-secrets-manager, and @aws-sdk/client-ssm to package.json.
    • Update zod version in package.json.

This description was created by Ellipsis for 1f6c68c. You can customize this summary. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 1f6c68c in 2 minutes and 17 seconds. Click for details.
  • Reviewed 1754 lines of code in 9 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. examples/gmail-viewer-cdk/lib/gmail-viewer-cdk-stack.ts:90
  • Draft comment:
    Using the non-null assertion for props.publicSubnets (line 90) may hide potential runtime issues if this value isn’t provided. Consider adding explicit validation or a fallback to ensure public subnets are valid when usePublicSubnets is true.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. examples/gmail-viewer/package.json:31
  • Draft comment:
    The 'zod' dependency version was downgraded from ^4.x to ^3.22.0. Please confirm this change is intentional given the breaking changes between v3 and v4.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_qS5WFVwEWSAritPM

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@akberc akberc merged commit 3264637 into main Jan 6, 2026
4 checks passed
@akberc akberc deleted the chore/update-ci-actions branch January 6, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant