fix: add AWS SDK peer dependencies for @dyanet/config-aws#17
Merged
Conversation
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to d10786e in 23 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
1files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. examples/gmail-viewer/package.json:26
- Draft comment:
Added @aws-sdk/credential-providers to meet the peer requirement; ensure its version (^3.0.0) stays consistent with the other AWS SDK packages. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_2zouOyXZDUm8ZeEH
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds required AWS SDK peer dependencies to gmail-viewer example:
These are peer dependencies of @dyanet/config-aws and must be installed for npm ci to succeed at runtime.
Important
Add AWS SDK peer dependencies to
gmail-viewerexample'spackage.jsonfor@dyanet/config-awscompatibility.@aws-sdk/credential-providerstodependenciesinpackage.jsonofgmail-viewerexample.@dyanet/config-awsby including necessary AWS SDK peer dependencies.This description was created by
for d10786e. You can customize this summary. It will automatically update as commits are pushed.