Skip to content

fix: add AWS SDK peer dependencies for @dyanet/config-aws#17

Merged
akberc merged 1 commit intomainfrom
fix/add-aws-sdk-peer-deps
Jan 6, 2026
Merged

fix: add AWS SDK peer dependencies for @dyanet/config-aws#17
akberc merged 1 commit intomainfrom
fix/add-aws-sdk-peer-deps

Conversation

@akberc
Copy link
Member

@akberc akberc commented Jan 6, 2026

Adds required AWS SDK peer dependencies to gmail-viewer example:

  • @aws-sdk/client-s3
  • @aws-sdk/client-secrets-manager
  • @aws-sdk/client-ssm
  • @aws-sdk/credential-providers

These are peer dependencies of @dyanet/config-aws and must be installed for npm ci to succeed at runtime.


Important

Add AWS SDK peer dependencies to gmail-viewer example's package.json for @dyanet/config-aws compatibility.

  • Dependencies:
    • Add @aws-sdk/credential-providers to dependencies in package.json of gmail-viewer example.
    • Ensure compatibility with @dyanet/config-aws by including necessary AWS SDK peer dependencies.

This description was created by Ellipsis for d10786e. You can customize this summary. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to d10786e in 23 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. examples/gmail-viewer/package.json:26
  • Draft comment:
    Added @aws-sdk/credential-providers to meet the peer requirement; ensure its version (^3.0.0) stays consistent with the other AWS SDK packages.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_2zouOyXZDUm8ZeEH

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@akberc akberc merged commit 8cc5e26 into main Jan 6, 2026
1 of 4 checks passed
@akberc akberc deleted the fix/add-aws-sdk-peer-deps branch January 6, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant