Fix/add aws sdk peer deps

[akberc]

Important

Update AWS SDK dependencies, modify Gmail Viewer CDK stack configuration, and adjust IMAP protocol tests to exclude 'NIL'.

• Dependencies:
  • Add @aws-sdk/credential-providers to package.json dependencies.
• Configuration:
  • Change apiCustomDomainName to demo.dyanet.com and update certificateArn in gmail-viewer-cdk.js, gmail-viewer-cdk.ts, gmail-viewer-cdk-stack.js, and gmail-viewer-cdk-stack.ts.
  • Update SecretsManager configuration in gmail-viewer-cdk-stack.js and gmail-viewer-cdk-stack.ts to include GOOGLE_CLIENT_ID, BASE_URL, and PORT.
  • Remove SSM parameters for BASE_URL, GOOGLE_CLIENT_ID, PORT, and NODE_ENV in gmail-viewer-cdk-stack.js and gmail-viewer-cdk-stack.ts.
• Tests:
  • Exclude 'NIL' from valid IMAP atoms in protocol.property.ts.

^{This description was created by for 3c17e4e. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 3c17e4e in 2 minutes and 6 seconds. Click for details.

• Reviewed 185 lines of code in 6 files
• Skipped 1 files when reviewing.
• Skipped posting 6 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. examples/gmail-viewer-cdk/bin/gmail-viewer-cdk.js:22

• Draft comment:
  Updated apiCustomDomainName and certificateArn values. Verify that 'demo.dyanet.com' and the new certificate ARN are correct for the target environment and consider externalizing these settings via context or environment variables.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

2. examples/gmail-viewer-cdk/bin/gmail-viewer-cdk.ts:23

• Draft comment:
  Updated apiCustomDomainName and certificateArn in TS file as well. Confirm these hardcoded values reflect the intended deployment settings.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm their intention regarding hardcoded values, which violates the rule against asking for confirmation of intention. It does not provide a specific suggestion or point out a clear issue with the code.

3. examples/gmail-viewer-cdk/lib/gmail-viewer-cdk-stack.js:165

• Draft comment:
  Secrets configuration updated: secretName now uses '/config' and GOOGLE_CLIENT_ID is added to secretObjectValue. Also, SSM parameter creation have been removed. Ensure that this change is backward compatible and that all application configs are obtained solely from Secrets Manager.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure backward compatibility and that all application configs are obtained solely from Secrets Manager. This falls under the category of asking the author to ensure certain behaviors, which is against the rules. The comment does not provide a specific code suggestion or ask for a specific test to be written.

4. examples/gmail-viewer-cdk/lib/gmail-viewer-cdk-stack.ts:167

• Draft comment:
  Similar update in the TS stack: secretObjectValue now includes GOOGLE_CLIENT_ID and uses '/config' as secretName. Verify all dependent components now read configuration from Secrets Manager as expected.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to verify that all dependent components read configuration from Secrets Manager as expected. This falls under the rule of not asking the author to ensure behavior is intended or to double-check things. Therefore, this comment should be removed.

5. examples/gmail-viewer/package.json:26

• Draft comment:
  Added dependency on '@aws-sdk/credential-providers'. Confirm that its version (^3.0.0) is compatible with the other AWS SDK packages used in the project.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to confirm compatibility of a dependency version, which is against the rules. It does not provide a specific suggestion or point out a specific issue with the code.

6. tests/property/protocol.property.ts:48

• Draft comment:
  The atom generator now filters out strings equal to 'NIL' (case-insensitive) to avoid reserved keyword conflicts. Ensure this aligns with your protocol specifications.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the PR author to ensure that the change aligns with protocol specifications, which is against the rules. It does not provide a specific suggestion or ask for a specific test to be written. Therefore, it should be removed.

Workflow ID: wflow_5gKUmxJgTAaAbJa0

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}