chore(security): add optional signing guard (disabled by default)#225
Open
karanheart96 wants to merge 180 commits intodydxprotocol:mainfrom
Open
chore(security): add optional signing guard (disabled by default)#225karanheart96 wants to merge 180 commits intodydxprotocol:mainfrom
karanheart96 wants to merge 180 commits intodydxprotocol:mainfrom
Conversation
* Add axios module * Minor fixes * Fix lint
* Add public clients * ks1 * ks2
* Add support for some private endpoints * Comment out broken code * Fix lint
* cleanup existing endpoints to meet undeployed Librarian and actually sign (dydxprotocol#5) * cleanup existing endpoints * fix * ks1 * Add remaining private endpoints except withdrawal (dydxprotocol#6) * cleanup existing endpoints * fix * additional endpoints * ks1 * Fix typo * Fixes for latest librarian * v0.0.4 * Fix lint * Fixes Co-authored-by: samweinberg23 <samweinberg23@gmail.com>
* Make minor fixes for integration tests * v0.0.5
* add create withdrawal * ks1 * ks2
* remove nsb-dev * ks1
* Update onboarding * v0.0.7
* add endpoints * update for public/private endpoints * ks1
* sign onboarding * ks1
* add key validation * ks1
* Fix provider type * Allow signing from web3 wallet * Add test for signing * Fix lint * v0.0.12
…4] (dydxprotocol#18) * add types * lint * silence test while auth is turned off
…l#17) * make authorization EIP712 and add helpers * tests * changes * ks1 * fix tests * ks2
* Minor cleanup * Fix types in signer.ts * Minor cleanup * Clean up modules * Clean up tests * Fix API key return types * Minor cleanup * expiresAt -> timestamp, and other minor cleanup * v0.0.16 * More readonly * url -> requestPath * Fix lint
* Allow onboarding signing to be done separately * Allow signing method to be passed to keys module * v0.0.17
* allow createUser to pass in a signature * eh1
* Update starkex-lib * Update starkex-lib
…xprotocol#174) * v1.8.1: [BAC-2441]: Add publicId to /v3/leaderboard-pnl endpoint * bump version
…dxprotocol#183) * add new param * tweaks * update ordering Co-authored-by: Eric Semeniuc <eric@dydx.exchange>
* BAC-2651 support generic parameter in createOrder * version bump to 1.8.5 * reorder params
…ydxprotocol#185) * v1.8.6: Add AffiliateApplicationStatus to profile/private endpoint * linter
* add reduceOnly param to v3-client * bump version
…otocol#195) * add liquidation to trade endpoint * 1.11.1
* v1.x.x getLiquidityProviderRewardsV2 * v1.11.3 * fix type
* v1.12.0 Ropsten -> Goerli * fix test * oops
* Bump starkex-eth for fresh goerli deployment * v1.13.0
Signed-off-by: James Jia - Test <james@dydx.exchange> Signed-off-by: James Jia - Test <james@dydx.exchange>
…ydxprotocol#215) * v1.14.2: Add deriveAllStarkKeys method, utilizing rotated signature * lint: fix * Onboarding: Consolidate stark key derivation signing and add test for signature rotation * Rotate v and t values * Nit: Edit description, remove newline * Nits: avoid mixing strings, return signature directly * Add async to signal that the method returns a promise.
* bump web3 to v1.3.6 * update starketh-eth to v0.16.1 * 1.15.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
blockintel-gate-sdkdependency for optional transaction signing guardblockintel-gate.ts— usesendWithGate(signer, tx)for Gate-protected transaction sends (opt-in)sendTransaction/signTransactionwithGate.guard()for opt-in securityHow to enable
Set env var
BLOCKINTEL_API_KEY(or equivalent config). The guard is disabled by default until configured.How to remove
Revert this commit.