This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Open
Conversation
Author
|
Closing this pull request until I am able to fix broken functionality due to the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to set a color scheme using
pywalas a module, such as in this example, alpha was not being correctly exported. In .Xresources, for instance, URxvt*background would be set with [100]#rrggbb. This pull request fixes this behavior by:Specifying a default value for the cases when alpha is not in data:
pywal/theme.py
and setting util.Color.alpha_num from data:
pywal/export.py
These changes can be appreciated in their context in the diff.
Open to implement further changes if I am missing something.
Thank you.