This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Enable wallpaper overrides when using a theme#709
Open
chriskingio wants to merge 1 commit intodylanaraps:masterfrom
Open
Enable wallpaper overrides when using a theme#709chriskingio wants to merge 1 commit intodylanaraps:masterfrom
chriskingio wants to merge 1 commit intodylanaraps:masterfrom
Conversation
Change such that `--theme` and `-i` no longer conflict; instead the `-i` flag will act as an override for the wallpaper of the theme. This has the added benefit of not rendering templates with a None value (such as `$wallpaper` in `sway-colors` when a wallpaper isn't defined.
|
give me dat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a change so that
--themeand-ino longer conflict; instead the-iflag will act as an override for the wallpaper of the theme.This has the added benefit of not rendering templates with a None value (such as
$wallpaperinsway-colorswhen a wallpaper isn't defined.I think this would fix #668 (as well as my own use case).