Implement protobuf serialization and component updates #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add protobuf-net package for binary serialization support - Add ProtobufSerializationBase.cs with base records for serialization - Add IProtobufSerializable interface for type contracts - Add ProtobufSerializableAttribute and SerializedMethodAttribute - Add JsSyncManager stub for JS interop with protobuf support - Add ProtobufSourceGenerator skeleton for future serialization code generation - Update ESBuildGenerator to use new shared project structure - Add SourceGenerator.Shared project with ProcessHelper and extension methods - Update Directory.Build.props with CoreProjectPath for source generators 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add TODO comments to placeholder implementations (SerializationExtensions, JsSyncManager, ProtobufSourceGenerator) documenting future work - Document ProtoMember(1000) magic number - reserved for base class properties to avoid conflicts with derived class tags (1-999) - Improve GeoBlazorMetaData exception handling - catch FileNotFoundException specifically instead of bare catch - Add XML documentation to GeoBlazorMetaData class and properties - Fix duplicate logging bug in ProcessHelper - output was being logged in ExitedCommandEvent then cleared, making error diagnostics empty 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…into feature/protobuf-serialization
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the full protobuf serialization system and includes various component updates. It is a stacked PR that builds on top of #493 (protobuf infrastructure) and must be merged after that PR is completed.
Depends on: #493 (Add protobuf serialization infrastructure)
Related Pro PR: https://github.com/dymaptic/GeoBlazor.Pro/pull/219 - These PRs should be reviewed together as they contain coordinated changes across both repositories.
What's Included
Protobuf Serialization Implementation (PR 1.5 from divergence analysis)
Geometry & Graphics Enhancements
Geometry.cs,Point.cs,Polygon.cs,Polyline.cs,Extent.cswith protobuf supportGraphic.cswith improved serializationSymbol.csand derived symbol classesMesh Geometry Support (3D)
MeshComponent.csandMeshComponent.gb.cs- Base mesh componentMeshMaterial.cs/.gb.cs- Mesh material definitionsMeshMaterialMetallicRoughness.cs/.gb.cs- PBR material supportMeshTexture.cs- Texture handlingMeshTextureTransform.cs/.gb.cs- Texture transformationMeshTransform.cs/.gb.cs- Mesh spatial transformsMeshVertexAttributes.cs/.gb.cs- Vertex attribute definitionsMeshGeoreferencedVertexSpace.cs,MeshLocalVertexSpace.cs- Vertex space typesPopup System Updates
PopupContent.cs,PopupTemplate.cs,PopupExpressionInfo.csComponent Updates
MapView.razor.cs- Enhanced view with protobuf supportMapComponent.razor.cs- Base component updatesSource Generator Updates
ProtobufSourceGenerator.csCoreSourceGeneratorTests.cswith comprehensive test coverageESBuildLauncherTests.csRoslynUtility.csfor test utilitiesTypeScript Updates
arcGisJsInterop.ts- Major updates for protobuf integrationbaseComponent.ts- New base component utilitiesgeoBlazorCore.ts- Core module updatesmapView.ts- MapView TypeScript enhancementsgraphic.ts- Graphic handling updatesPerformance Benefits
Binary serialization via protobuf-net provides significant improvements for Blazor Server scenarios:
Relationship to PR Series
This PR is part of a planned series to merge changes from
feature/478-multipart-operatorincrementally (see BRANCH_DIVERGENCE_ANALYSIS.md):Statistics
Test Plan
ran testscommit)Review Notes
Please review this PR alongside the Pro PR:
The mesh component additions in this PR correspond to mesh component removals in the Pro PR (moved from Pro to Core).
🤖 Generated with Claude Code