Test Runner and GitHub Actions Improvements #502
Conversation
|
Claude finished @TimPurdum's task —— View job Issues FoundCritical Issue in TestApi.cs:8 extension(WebApplication app)This syntax is invalid C#. Should be: public static class TestApiExtensions
{
public static void MapTestLogger(this WebApplication app)
{
// existing code
}
public static void MapApplicationManagement(this WebApplication app)
{
// existing code
}
}Potential Issue in TestApi.cs:24 Environment.ExitCode = int.Parse(exitCode);Missing error handling for invalid exit codes. Should use Race Condition in Index.razor:194-195 attemptCount++;
await JsRuntime.InvokeVoidAsync("localStorage.setItem", "runAttempts", attemptCount);The attempt count is incremented after checking the limit but before storing, creating a potential race condition. Should increment and store atomically. HTTP Fire-and-Forget in WasmApplicationLifetime.cs:18 _ = httpClient.PostAsync($"exit?exitCode={Environment.ExitCode}", null);The HTTP call is fire-and-forget without await, potentially causing the application to exit before the request completes. This could lead to unreliable exit code reporting. Missing Null Check in Index.razor:284 if (_results!.TryGetValue(kvp.Key, out TestResult? results))Uses null-forgiving operator but |
|
Claude finished @TimPurdum's task —— View job PR Review CompleteTodo List:
Review SummaryI've reviewed the changed files and confirmed that the critical issues identified in the previous review are still present. Since those issues have already been documented and per instructions to avoid repeating previous comments, no new actionable issues were found that require additional attention. The previous review already identified the key issues that need to be addressed:
|
|
Claude finished @TimPurdum's task —— View job PR Review CompleteTodo List:
Review SummaryI've reviewed the changed files and confirmed that the critical issues identified in the previous review are still present. Since those issues have already been documented and per instructions to avoid repeating previous comments, no new actionable issues were found that require additional attention. The previous review already identified the key issues that need to be addressed:
|
|
Claude finished @TimPurdum's task —— View job PR Review CompleteTodo List:
Review SummaryI've reviewed the changed files and confirmed that the critical issues identified in the previous review are still present. Since those issues have already been documented and per instructions to avoid repeating previous comments, no new actionable issues were found that require additional attention. The previous review already identified the key issues that need to be addressed:
|
|
Claude finished @TimPurdum's task —— View job PR Review CompleteTodo List:
Review SummaryI've reviewed the changed files and confirmed that the critical issues identified in the previous review are still present. Since those issues have already been documented and per instructions to avoid repeating previous comments, no new actionable issues were found that require additional attention. The previous review already identified the key issues that need to be addressed:
|
|
Claude finished @TimPurdum's task —— View job PR Review CompleteTodo List:
Review SummaryI've reviewed the changed files and confirmed that the critical issues identified in the previous review are still present. Since those issues have already been documented and per instructions to avoid repeating previous comments, no new actionable issues were found that require additional attention. The previous review already identified the key issues that need to be addressed:
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude finished @TimPurdum's task —— View job PR Review CompleteTodo List:
Review SummaryI've reviewed the changed files and confirmed that the critical issues identified in the previous review are still present. Since those issues have already been documented and per instructions to avoid repeating previous comments, no new actionable issues were found that require additional attention. The previous review already identified the key issues that need to be addressed:
|
|
Claude finished @TimPurdum's task —— View job PR Review CompleteTodo List:
Review SummaryI've reviewed the changed files and confirmed that the critical issues identified in the previous review are still present. Since those issues have already been documented and per instructions to avoid repeating previous comments, no new actionable issues were found that require additional attention. The previous review already identified the key issues that need to be addressed:
|
|
Claude finished @TimPurdum's task —— View job PR Review CompleteTodo List:
Review SummaryI've reviewed the changed files and confirmed that the critical issues identified in the previous review are still present. Since those issues have already been documented and per instructions to avoid repeating previous comments, no new actionable issues were found that require additional attention. The previous review already identified the key issues that need to be addressed:
|
- Simplified and improved test method source generation in `GenerateTests.cs`. - Enhanced handling of attributes and class-level declarations. - Added `[CICondition(ConditionMode.Exclude)]` to specific test methods and classes. - Removed unused `GenerateTestName` method from `GeoBlazorTestClass`.
|
Claude finished @TimPurdum's task —— View job PR Review CompleteTodo List:
Review SummaryI've reviewed the changed files and confirmed that the critical issues identified in the previous review are still present. Since those issues have already been documented and per instructions to avoid repeating previous comments, no new actionable issues were found that require additional attention. The previous review already identified the key issues that need to be addressed:
|
…d location data - Moved orphaned test run cleanup in TestConfig.cs - Increased workflow test timeout to 90 minutes - Fixed test runner filter logic in TestRunnerBase.razor.cs - Updated test data to new locations in LocationServiceTests.cs
|
Claude finished @TimPurdum's task —— View job PR Review CompleteTodo List:
Review SummaryI've reviewed the changed files and confirmed that the critical issues identified in the previous review are still present. Since those issues have already been documented and per instructions to avoid repeating previous comments, no new actionable issues were found that require additional attention. The previous review already identified the key issues that need to be addressed:
|
Summary
This PR merges test runner and GitHub Actions improvements from the
v5.0branch intodevelop.Test Runner Enhancements
RunOnStartcascading parameter to automatically run tests when the application startsTestFilterregex parameter to run only specific test classesITestLoggerinterface withServerTestLoggerandClientTestLoggerimplementations for consistent logging across Server and WebAssembly modesIHostApplicationLifetimefor WebAssembly to signal test completionJsTestRunneris now passed as a parameter to avoid redundant module loadingGitHub Actions Updates
dev-pr-build.ymlnow uses self-hosted Windows runner for buildstestjob that runs the GeoBlazor test runner automaticallyOther Changes
CLAUDE.mdwith improved build and test commandsnuget.configfor package sourcesTest Plan
🤖 Generated with Claude Code