Skip to content

chore: fix log + clean up #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dynamic-calm merged 2 commits into from
Dec 20, 2025
Merged

chore: fix log + clean up #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a21030
chore: fix log + clean up
dynamic-calm Dec 20, 2025
516c0c7
chore: update readme
dynamic-calm Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
)

func main() {
client, _ := mokv.NewClient("localhost:8400")
client, _ := mokv.NewClient("addr")
defer client.Close()

ctx := context.Background()
Expand Down
7 changes: 4 additions & 3 deletions discovery/picker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ func (p *Picker) Pick(info balancer.PickInfo) (balancer.PickResult, error) {
}

methodName := info.FullMethodName
isWrite := strings.Contains(methodName, "Set") ||
strings.Contains(methodName, "Delete")

// No available connections
if p.leader == nil && len(p.followers) == 0 {
Expand All @@ -78,10 +76,13 @@ func (p *Picker) Pick(info balancer.PickInfo) (balancer.PickResult, error) {
return result, balancer.ErrNoSubConnAvailable
}

isWrite := strings.Contains(methodName, "Set") ||
strings.Contains(methodName, "Delete")

// Write operations must go to leader
if isWrite {
if p.leader == nil {
log.Debug().
log.Warn().
Str("method", methodName).
Msg("pick failed: write operation but no leader")
return result, balancer.ErrNoSubConnAvailable
Expand Down