Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the logic to calculate and populate the
ingested_forecast_lengthcoordinate for the GFS dataset, as requested in #412.This metric helps downstream users determine the maximum available lead time for each initialization time, allowing them to filter for "complete" forecasts.
Changes
src/reformatters/common/ingest_stats.pywith a new functionupdate_ingested_forecast_length.HasTimeInfoProtocol to ensure type safety when processing coordinates.init_timeand updates the dataset in place.src/reformatters/noaa/gfs/region_job.py.update_template_with_resultsto call the new utility after the standard update process.tests/common/test_ingest_stats.pyto verify:pd.NaTand empty states.Testing
tests/common/test_ingest_stats.py.ty(usingtype: ignorefor specific pandas timedelta edge cases).Related Issue
Closes #412
CC @aldenks @JackKelly