- Honour "addressdetails: 0" in options.#1
Open
lyle-sigurdson wants to merge 1 commit intodynmeth:masterfrom
lyle-sigurdson:master
Open
- Honour "addressdetails: 0" in options.#1lyle-sigurdson wants to merge 1 commit intodynmeth:masterfrom lyle-sigurdson:master
lyle-sigurdson wants to merge 1 commit intodynmeth:masterfrom
lyle-sigurdson:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried addressdetails: 0 when passing options to nominatim.search, I noticed that it was still specifying addressdetails: 1 (the default) to nominatim.openstreemap.org.
The problem is in the check to see if the passed in options object already has the keys the defaults object has.
You're actually checking against the value of the key in the passed in options, so if a value is 0, the logic overwrites the passed in option with the default.
My fix checks to see if the value is defined instead of checking truthyness.
My fix isn't tested extensively, but it is working for my situation.