Conversation
github-actions
bot
added
web
omdxp
reviewed
Dec 21, 2024
ZibanPirate
force-pushed
the
feat/contribution-page
branch
from
a45edde to
4eda964
Compare
ZibanPirate
force-pushed
the
feat/contribution-page
branch
from
4eda964 to
a5c73d3
Compare
omdxp
reviewed
Dec 30, 2024
omdxp
reviewed
Dec 30, 2024
Comment on lines
+19
to
+26
| contribution: Pick< | ||
| ContributionEntity, | ||
| "id" | "title" | "type" | "url" | "updatedAt" | "activityCount" | ||
| > & { | ||
| repository: Pick<RepositoryEntity, "id" | "owner" | "name"> & { | ||
| project: Pick<ProjectEntity, "id" | "name">; | ||
| }; | ||
| contributor: Pick<ContributorEntity, "id" | "name" | "username" | "avatarUrl">; |
Contributor
There was a problem hiding this comment.
We should improve these types so it can be easy to be shared
Member
Author
There was a problem hiding this comment.
any particular action item for this PR? or this is a general point that we should address at some point?
Contributor
There was a problem hiding this comment.
I'd say just a general note for later, like allowing type aliases for readability
omdxp
previously approved these changes
Dec 30, 2024
Contributor
omdxp
left a comment
omdxp
left a comment
There was a problem hiding this comment.
Approved with some action items next PRs
omdxp
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.