Open
Conversation
3d conformal now no longer errors out when used together with sequencing, the issue here was the inconsonant number of bixels in the stf, which is why the collapseStf function was added. Also changes to the sequencer were made to accomondate for example a beam with 0 weight vector.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #885 +/- ##
==========================================
- Coverage 53.85% 53.76% -0.09%
==========================================
Files 308 309 +1
Lines 19938 19967 +29
==========================================
- Hits 10737 10736 -1
- Misses 9201 9231 +30 ☔ View full report in Codecov by Sentry. |
wahln
changed the title
wahln
requested changes
Feb 2, 2026
Contributor
wahln
left a comment
wahln
left a comment
There was a problem hiding this comment.
The tests are failing for some reason due to a missing "sum field".
| sequencing.beam(i).shapesWeight = zeros(dimOfFluenceMxZ,dimOfFluenceMxX); | ||
| sequencing.beam(i).bixelIx = 1+offset:numOfRaysPerBeam+offset; | ||
| sequencing.beam(i).fluence = zeros(dimOfFluenceMxZ,dimOfFluenceMxX); | ||
| sequencing.beam(i).sum = zeros(dimOfFluenceMxZ,dimOfFluenceMxX); |
Contributor
There was a problem hiding this comment.
In the tests, something is not working out with the "sum" field hier.
| sequencing.beam(i).shapesWeight = shapesWeight(1:k)/numOfLevels*calFac; | ||
| sequencing.beam(i).bixelIx = 1+offset:numOfRaysPerBeam+offset; | ||
| sequencing.beam(i).fluence = D_0; | ||
| sequencing.beam(i).sum = zeros(dimOfFluenceMxZ,dimOfFluenceMxX); |
Contributor
There was a problem hiding this comment.
I think here the tests also have an issue with the sum field
| sequencing.beam(i).shapesWeight = zeros(dimOfFluenceMxZ,dimOfFluenceMxX); | ||
| sequencing.beam(i).bixelIx = 1+offset:numOfRaysPerBeam+offset; | ||
| sequencing.beam(i).fluence = zeros(dimOfFluenceMxZ,dimOfFluenceMxX); | ||
| sequencing.beam(i).sum = zeros(dimOfFluenceMxZ,dimOfFluenceMxX); |
Contributor
Author
There was a problem hiding this comment.
i removed the field sum, it is apparently only used for the sochi sequencer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3d conformal now no longer errors out when used together with sequencing, the issue here was the inconsonant number of bixels in the stf, which is why the collapseStf function was added. Also changes to the sequencer were made to accomondate for example a beam with 0 weight vector.
this also reminded me that we should finish the work on the class based sequencers