Reopening pull request #2065 forum userlist wrapping

[rica-carv]

Reopening issue #2065

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist

• My code adheres to the e107 code style standard.
• I have read the contributing document.
• I have added tests to cover my changes.
• All new and existing tests pass.

[Jimmi08]

@rica-carv
I appreciate your work so now I am trying to understand what you did.

This PR will be never approved. forum shortcodes file is already updated and there is a conflict in it with your code.

In the original PR @CaMer0n already told you that it breaks old themes. My objections are that you didn't fix this shortcode fully.

Link to user profile should use e107::getUrl() way, not hardcoded HTML code. On one place you are removing it, but on other place you let it there.

global $listuserson; - should be $listuserson = e107::getOnline()->userList();

return; should be return "";

user link should be:

		$uparams = array('id' => $oid, 'name' => $oname;
		$link = e107::getUrl()->create('user/profile/view', $uparams);

Everything is already managed (new way) in online plugin
It should be done similar way as in $ONLINE_MENU_TEMPLATE['default']['online_members_list_extended']

I hope it helps somehow. The original issue should be opened, because this should be fixed. Thanks

Next notes:

• online users under forum should be all users or only users on forum?
• online user area detection fails because of SEF-URLs. Online_location is used as e_REQUEST_URI but all checks are against URL format forum.php, news.php etc.

[rica-carv]

@Jimmi08 Sorry, but i don't understand your post. If you check both files i changed, i only take out hardcode html inside the forum_shortcodes.php file to forum_template.php file!
I didn't do anything else...

All the changes you're speaking were already there, so i don't see any other conflict....

I think you're mixing up old change with my new ones.... and i don't understand the changes you're talking about....

[qlty-cloud-legacy]

Code Climate has analyzed commit 2d5f127 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 66.6% (80% is the threshold).

This pull request will bring the total coverage in the repository to 41.8% (-7.1% change).

View more on Code Climate.