Forum quickreply templatization

[rica-carv]

Motivation and Context

Enable custom template for the forum quick reply form

Description

Changed code to take hardcoded HTML from forum quickreply shortcode to template

How Has This Been Tested?

Latest e107 github code

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist

• My code adheres to the e107 code style standard.
• I have read the contributing document.
• I have added tests to cover my changes.
• All new and existing tests pass.

[qlty-cloud-legacy]

Code Climate has analyzed commit 90ce61e and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Bug Risk	1

The test coverage on the diff in this pull request is 7.1% (80% is the threshold).

This pull request will bring the total coverage in the repository to 39.0% (0.0% change).

View more on Code Climate.

[CaMer0n]

@rica-carv Thank you for this! I left some comments. Just some minor tweaks and then I can commit it. Thank you.
Basically the form fields should all be shortcodes (other than 'form'). In other words, a bad template should not be able to break the functionality of the form.

[rica-carv]

I left some comments.

@CaMer0n Sorry, but i don't see any coments.... anywhere....

[CaMer0n]

@rica-carv Sorry, It appears they went into a 'pending' state. Do you see them now?

[rica-carv]

Do you see them now?

@CaMer0n Yes i do. Tx

[rica-carv]

Done.
Added default template for legacy purposes, althought it's akward to remove embbebed HTML asd then left it there for legacy purposes....

[CaMer0n]

Thanks. It's definitely better. Unfortunately, all the unit tests failed. Adding a defset('e_TOKEN') on e_TOKEN should fix it.
I added some more notes. We want to separate functionality from design, so that a theme developer can't break the functionality of the form.

---

1. e_parse_shortcodeTest: Forum view shortcodes
   Test tests/unit/e_parse_shortcodeTest.php:testForumViewShortcodes

Error: ;1m [Error] Undefined constant "e_TOKEN"

#1 /__w/e107/e107/e107_plugins/forum/shortcodes/batch/view_shortcodes.php:1411
#2 /__w/e107/e107/e107_handlers/shortcode_handler.php:1154
#3 e_parse_shortcode->doCode
#4 /__w/e107/e107/e107_handlers/shortcode_handler.php:1020
#5 /__w/e107/e107/e107_handlers/e_parse_class.php:854
#6 /__w/e107/e107/e107_tests/tests/unit/e_parse_shortcodeTest.php:1717
#7 /__w/e107/e107/e107_tests/tests/unit/e_parse_shortcodeTest.php:1367
#8 /__w/e107/e107/e107_tests/vendor/bin/codecept:119

[rica-carv]

@CaMer0n I've got some more pulls regarding moving HTML to templates, if you have the time to have a look...

[rica-carv]

@CaMer0n Think got it all donne... can you review it, please?