-
Notifications
You must be signed in to change notification settings - Fork 16
Raise CMake minimum version to 3.16, CMake fixes, update Homepage #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
These changes break the build. |
I've checked all build logs and
|
500247c to
1c53c0a
Compare
|
I agree that the CMake version needs to be bumped up, especially since it differs in various places. But I don't see the point of commit 3755074, which changes working code. I read the explanation in your links, but I think the problem is exaggerated. |
|
Why is this closed? I'm just away from git access for a couple of days before I can address your comments. |
I removed KDE support and this makes bug 964965 irrelevant. |
|
This PR is unrelated to KDE support. |
|
Do you still need this PR? |
|
I'll get to it and rebase later. |
CMake 3.31 warns about compat. for <3.10 being removed in the future. Qt6 CMake modules already require 3.16 though, so it is a good base line. CMake 3.16 was released in 2019. Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
See also: https://invent.kde.org/plasma/libplasma/-/merge_requests/267 https://cmake.org/cmake/help/latest/command/if.html#variable-expansion https://cmake.org/cmake/help/latest/policy/CMP0054.html#policy:CMP0054 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
1c53c0a to
5cc9a5a
Compare
I've kept this for now, but as last commit. If you do not like it at all, you can pick the first two commits only, alternatively I can drop it in another force-push. I have had to fix nasty issues related to the CMake variables in if() in the past, so it is definitely a thing. Sure the code works now, but this way of doing it is prone to subtle breakage when it suddenly doesn't work anymore. (this is also more in line with 99% of other CMake build systems out there, of which I have seen probably thousands) |
Raise CMake minimum version to 3.16
CMake 3.31 warns about compat. for <3.10 being removed in the future. Qt6
CMake modules already require 3.16 though, so it is a good base line.
CMake 3.16 was released in 2019.
Do not expand variables beforehand
See also:
https://invent.kde.org/plasma/libplasma/-/merge_requests/267
https://cmake.org/cmake/help/latest/command/if.html#variable-expansion
https://cmake.org/cmake/help/latest/policy/CMP0054.html#policy:CMP0054
Update Homepage throughout repository (misc)