Skip to content

Conversation

@a17r
Copy link
Contributor

@a17r a17r commented Oct 23, 2025

@a17r a17r mentioned this pull request Oct 23, 2025
@u-235
Copy link
Member

u-235 commented Oct 23, 2025

These changes break the build.

@a17r
Copy link
Contributor Author

a17r commented Oct 23, 2025

These changes break the build.

I've checked all build logs and none of them are one of them is related to my changes fwics. 1) I have not initialised bundled chmlib in my fork [I hope I've found the reason there] 2) the libzip version (1.7.3 is very old) that is being attempted to be installed for macOS is too old for >=CMake-4 which seems to be part of your CI setup now (1.11.4 would fix that).

Do you have different build.log for me?

@a17r a17r force-pushed the cmake-3.16-minimum branch 2 times, most recently from 500247c to 1c53c0a Compare October 23, 2025 19:41
@u-235
Copy link
Member

u-235 commented Oct 24, 2025

I agree that the CMake version needs to be bumped up, especially since it differs in various places. But I don't see the point of commit 3755074, which changes working code. I read the explanation in your links, but I think the problem is exaggerated.

@u-235 u-235 closed this Oct 25, 2025
@a17r
Copy link
Contributor Author

a17r commented Oct 26, 2025

Why is this closed? I'm just away from git access for a couple of days before I can address your comments.

@u-235
Copy link
Member

u-235 commented Oct 29, 2025

Why is this closed?

I removed KDE support and this makes bug 964965 irrelevant.

@a17r
Copy link
Contributor Author

a17r commented Oct 29, 2025

This PR is unrelated to KDE support.

@u-235 u-235 reopened this Oct 30, 2025
@u-235
Copy link
Member

u-235 commented Nov 3, 2025

Do you still need this PR?

@a17r
Copy link
Contributor Author

a17r commented Nov 3, 2025

I'll get to it and rebase later.

a17r added 3 commits November 3, 2025 21:44
CMake 3.31 warns about compat. for <3.10 being removed in the future. Qt6
CMake modules already require 3.16 though, so it is a good base line.

CMake 3.16 was released in 2019.

Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
@a17r a17r force-pushed the cmake-3.16-minimum branch from 1c53c0a to 5cc9a5a Compare November 3, 2025 20:56
@a17r
Copy link
Contributor Author

a17r commented Nov 3, 2025

But I don't see the point of commit 3755074, which changes working code. I read the explanation in your links, but I think the problem is exaggerated.

I've kept this for now, but as last commit. If you do not like it at all, you can pick the first two commits only, alternatively I can drop it in another force-push.

I have had to fix nasty issues related to the CMake variables in if() in the past, so it is definitely a thing. Sure the code works now, but this way of doing it is prone to subtle breakage when it suddenly doesn't work anymore. (this is also more in line with 99% of other CMake build systems out there, of which I have seen probably thousands)

@u-235 u-235 merged commit 14eadf0 into eBookProjects:master Nov 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants