fix: Jester kill screen shows only Prosecutor when prosecuted (Fixes …#357
fix: Jester kill screen shows only Prosecutor when prosecuted (Fixes …#357t91a60 wants to merge 1 commit intoeDonnes124:masterfrom
Conversation
…Donnes124#291) ### Problem When a **Prosecutor** prosecutes the **Jester**, the Jester's post-death kill screen incorrectly displays *all voters* (including non-Prosecutors) instead of only the Prosecutor. This caused confusion, as the Jester could haunt players who did not prosecute them. **Reported by**: [@Nommabelle](https://github.com/Nommabelle) in [eDonnes124#291](eDonnes124#291). ### Changes 1. **Track Prosecution**: - Added `ProsecutedBy` field to the Jester role to track the Prosecutor. - Updated `Prosecutor.Prosecute()` to assign the prosecuting player to the Jester. 2. **Haunt Logic Fix**: - Modified `Jester.Haunt()` to prioritize the Prosecutor (if prosecuted). 3. **Meeting UI Fix**: - Force the Prosecutor's vote to appear **purple** in meetings when prosecuting a Jester. 4. **Edge Cases**: - Reset `ProsecutedBy` at the start of each game. - Handle dead/disconnected Prosecutors gracefully. ### Testing - **Scenario 1**: Prosecutor prosecutes Jester → Kill screen **only shows Prosecutor (purple)**. - **Scenario 2**: Jester voted out without prosecution → All voters appear. - **Scenario 3**: Prosecutor disconnects/dies → Jester's kill screen defaults to voters. ### Notes - Improves gameplay clarity by ensuring only the Prosecutor is held accountable. - Compatible with existing roles (Mayor, Swapper, etc.).
|
first time in C#, correct me if am wrong |
|
I haven't done anything about this issue because I don't feel a need to. It shows all players who would have voted them anyway so in my opinion, it is working fine. I guess it could be considered a bug but in my opinion it allows the Jester to haunt anyone who was voting for them anyway. I can always change this in the future but for now I think it is fine as is. This also occurs with Executioner torment (I assume). |
|
a few days ago i got prosecuted as jester and my torment only showed the prosecutor so there might be more to it, maybe no one else had voted me yet |
that has an easy explanation that you've already given. |
4 participants
…#291)
Problem
When a Prosecutor prosecutes the Jester, the Jester's post-death kill screen incorrectly displays all voters (including non-Prosecutors) instead of only the Prosecutor. This caused confusion, as the Jester could haunt players who did not prosecute them.
Reported by: @Nommabelle in #291.
Changes
Track Prosecution:
ProsecutedByfield to the Jester role to track the Prosecutor.Prosecutor.Prosecute()to assign the prosecuting player to the Jester.Haunt Logic Fix:
Jester.Haunt()to prioritize the Prosecutor (if prosecuted).Meeting UI Fix:
Edge Cases:
ProsecutedByat the start of each game.Testing
Notes