Skip to content

[#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files. #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 25, 2025
Merged

[#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files. #207

merged 6 commits into from
Sep 25, 2025
+72 −0

Conversation

@KeaneWong
Copy link
Contributor

@KeaneWong KeaneWong commented Feb 20, 2025 •
edited by MiguelCompany
Loading

Description

Currently, the way that CMake creates the library files always generates .dylib files on Mac. Compilation will work fine, but attempting to import in any Python app will cause the import to fail, as the interpreter expects .so files for library files.
For some reason, using the flag
--cmake-args " -DCMAKE_SHARED_LIBRARY_SUFFIX=.so"
does not fix the issue. Additionally, setting the variable before the project() line in the CMakeLists also remains inneffective. So, the workaround is to add
set(CMAKE_SHARED_LIBRARY_SUFFIX .so)
right after the project() line.

@Mergifyio backport 2.3.x 2.2.x 1.4.x

Fixes #206

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Changes are API compatible.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Danipiza Danipiza force-pushed the fix/mac-dylib-generation branch from 52c299e to a336102 Compare July 30, 2025 09:47
@Danipiza Danipiza changed the title Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files. [#23543] Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files. Jul 30, 2025
richiware
richiware requested changes Aug 26, 2025
View reviewed changes
@Danipiza Danipiza mentioned this pull request Sep 22, 2025
Merged
9 tasks
Keane Wong and others added 6 commits September 25, 2025 09:51
@MiguelCompany
Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.
17d3eb0
@Danipiza @MiguelCompany
[#23543] Added cmake option and default suffix for platforms
2e2e880 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza @MiguelCompany
[#23543] Added cmake option for Python test and examples
8d5468b 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza @MiguelCompany
[#23543] Default value for Windows OS
061f3d2 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza @MiguelCompany
[#23543] Review changes
9fcf244 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@MiguelCompany
Refs #23543. Regenerate code with Fast DDS Gen from related PR.
739e7d9 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany added this to the v2.4.0 milestone Sep 25, 2025
@MiguelCompany MiguelCompany force-pushed the fix/mac-dylib-generation branch from 6b1355a to 739e7d9 Compare September 25, 2025 07:56
@MiguelCompany
Copy link
Member

MiguelCompany commented Sep 25, 2025

CI:

@MiguelCompany MiguelCompany merged commit 57a5541 into eProsima:main Sep 25, 2025
2 checks passed
@MiguelCompany
Copy link
Member

MiguelCompany commented Sep 25, 2025

@Mergifyio backport 2.3.x 2.2.x 1.4.x

@mergify
Copy link

mergify bot commented Sep 25, 2025 •
edited
Loading

backport 2.3.x 2.2.x 1.4.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 25, 2025
@KeaneWong @Danipiza
@MiguelCompany @mergify
Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files (#207)
e7ac6d4 
* Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.

* [#23543] Added cmake option and default suffix for platforms

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#23543] Added cmake option for Python test and examples

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#23543] Default value for Windows OS

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#23543] Review changes

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* Refs #23543. Regenerate code with Fast DDS Gen from related PR.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Keane Wong <kwong@FELT241.FluxErgy.local>
Co-authored-by: danipiza <dpizarrogallego@gmail.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 57a5541)
mergify bot pushed a commit that referenced this pull request Sep 25, 2025
@KeaneWong @Danipiza
@MiguelCompany @mergify
Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files (#207)
42d339f 
* Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.

* [#23543] Added cmake option and default suffix for platforms

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#23543] Added cmake option for Python test and examples

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#23543] Default value for Windows OS

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#23543] Review changes

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* Refs #23543. Regenerate code with Fast DDS Gen from related PR.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Keane Wong <kwong@FELT241.FluxErgy.local>
Co-authored-by: danipiza <dpizarrogallego@gmail.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 57a5541)
mergify bot pushed a commit that referenced this pull request Sep 25, 2025
@KeaneWong @mergify
Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files (#207)
a7b2e9b 
* Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.

* [#23543] Added cmake option and default suffix for platforms

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#23543] Added cmake option for Python test and examples

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#23543] Default value for Windows OS

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* [#23543] Review changes

Signed-off-by: danipiza <dpizarrogallego@gmail.com>

* Refs #23543. Regenerate code with Fast DDS Gen from related PR.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>

---------

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Keane Wong <kwong@FELT241.FluxErgy.local>
Co-authored-by: danipiza <dpizarrogallego@gmail.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
(cherry picked from commit 57a5541)

# Conflicts:
#	fastdds_python/test/types/test_complete.i
#	fastdds_python/test/types/test_modules.i
#	fastdds_python_examples/RPCExample/generated_code/CMakeLists.txt
This was referenced Sep 25, 2025
Merged
Merged
Open
Merged
MiguelCompany added a commit that referenced this pull request Sep 25, 2025
@mergify @KeaneWong
@Danipiza @MiguelCompany
Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files (#207) (#258)
4ee6ecf 
* Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.

* [#23543] Added cmake option and default suffix for platforms



* [#23543] Added cmake option for Python test and examples



* [#23543] Default value for Windows OS



* [#23543] Review changes



* Refs #23543. Regenerate code with Fast DDS Gen from related PR.



---------






(cherry picked from commit 57a5541)

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Keane Dixon Wong <Keanewong913@gmail.com>
Co-authored-by: Keane Wong <kwong@FELT241.FluxErgy.local>
Co-authored-by: danipiza <dpizarrogallego@gmail.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
MiguelCompany added a commit that referenced this pull request Sep 25, 2025
@mergify @KeaneWong
@Danipiza @MiguelCompany
Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files (#207) (#257)
e7414b4 
* Set CMAKE_SHARED_LIBRARY_SUFFIX to always create .so files.

* [#23543] Added cmake option and default suffix for platforms



* [#23543] Added cmake option for Python test and examples



* [#23543] Default value for Windows OS



* [#23543] Review changes



* Refs #23543. Regenerate code with Fast DDS Gen from related PR.



---------






(cherry picked from commit 57a5541)

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: Keane Dixon Wong <Keanewong913@gmail.com>
Co-authored-by: Keane Wong <kwong@FELT241.FluxErgy.local>
Co-authored-by: danipiza <dpizarrogallego@gmail.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
@mergify mergify bot mentioned this pull request Sep 26, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Danipiza Danipiza Danipiza left review comments

@richiware richiware richiware approved these changes

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.4.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

FastDDS Python generates .dylib files instead of .so files on MacOS

4 participants

@KeaneWong @MiguelCompany @richiware @Danipiza