Add support for sql null types#66
Open
adam-frisby wants to merge 2 commits intoeaigner:masterfrom
adam-frisby:null-branch
Open
Add support for sql null types#66adam-frisby wants to merge 2 commits intoeaigner:masterfrom adam-frisby:null-branch
adam-frisby wants to merge 2 commits intoeaigner:masterfrom
adam-frisby:null-branch
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds Null* types from the database/sql package to the Hood SQL Types and adds support for the types in SetModelValue. I've tested the changes with both mysql and postgresql. Everything looks to be working as expected. This will allow hood to handle values which may be null.
Example:
Retrieving the row which was inserted by tx.Save(&c) above will give you a sql.NullInt64{0, false} for Number
Question: Since normal types (int, string, etc) can't represent a null value, should the notnull keyword be removed and assumed to be not null unless the column type is of type NullBool, NullInt64, etc?