fix(memory): skip ingestion when Gemini API key is not configured#37
Open
mikekidder wants to merge 1 commit intoearlyaidopters:mainfrom
Open
fix(memory): skip ingestion when Gemini API key is not configured#37mikekidder wants to merge 1 commit intoearlyaidopters:mainfrom
mikekidder wants to merge 1 commit intoearlyaidopters:mainfrom
Conversation
Prevents memory-ingest from calling Gemini when GOOGLE_API_KEY is unset, which would throw an unhandled error for users without Gemini configured. Note: We submitted a version of this fix previously but it appears to have not made it into recent builds. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GOOGLE_API_KEYguard at the top ofingestConversationTurn()insrc/memory-ingest.ts, so memory ingestion is silently skipped when Gemini is not configuredTest plan
GOOGLE_API_KEYset in.envand confirm no crashes occur during conversationGOOGLE_API_KEYset and confirm memory ingestion still works as expectednpm run buildcompletes without errors🤖 Generated with Claude Code