Skip to content

Fix: skip Obsidian/Claude Code install when already present #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Levis44 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: skip Obsidian/Claude Code install when already present #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,22 +113,29 @@ fi
# ─── STEP 3: Obsidian ────────────────────────────────────────────────────────
echo ""
echo -e "${WHITE}Step 2/7 — Installing Obsidian${RESET}"
if ! brew list --cask obsidian &>/dev/null 2>&1; then
echo " Installing Obsidian..."
brew install --cask obsidian
echo -e " ${GREEN}✓${RESET} Obsidian installed"
else
# Check brew AND direct DMG install (/Applications/Obsidian.app)
if brew list --cask obsidian &>/dev/null 2>&1 || [ -d "/Applications/Obsidian.app" ]; then
echo -e " ${GREEN}✓${RESET} Obsidian already installed"
else
echo " Installing Obsidian..."
if brew install --cask obsidian; then
echo -e " ${GREEN}✓${RESET} Obsidian installed"
else
echo -e " ${ORANGE}⚠${RESET} Could not install via Homebrew. Download from: https://obsidian.md/download"
fi
fi

# ─── STEP 4: Claude Code ─────────────────────────────────────────────────────
echo ""
echo -e "${WHITE}Step 3/7 — Installing Claude Code CLI${RESET}"
if ! command -v claude &>/dev/null; then
echo " Installing Claude Code..."
curl -fsSL https://claude.ai/install.sh | sh
echo -e " ${GREEN}✓${RESET} Claude Code installed"
echo -e " ${DIM} Note: restart terminal if 'claude' isn't found after setup${RESET}"
if curl -fsSL https://claude.ai/install.sh | sh; then
echo -e " ${GREEN}✓${RESET} Claude Code installed"
echo -e " ${DIM} Note: restart terminal if 'claude' isn't found after setup${RESET}"
else
echo -e " ${ORANGE}⚠${RESET} Install failed. Try manually: npm install -g @anthropic-ai/claude-code"
fi
else
echo -e " ${GREEN}✓${RESET} Claude Code already installed"
fi
Expand Down Expand Up @@ -371,7 +378,7 @@ echo -e " ${WHITE}Checking installation...${RESET}"
echo -e " ${DIM}(Any failures above are safe to retry — just re-run this script.)${RESET}"
echo ""

if brew list --cask obsidian &>/dev/null 2>&1; then
if brew list --cask obsidian &>/dev/null 2>&1 || [ -d "/Applications/Obsidian.app" ]; then
echo -e " ${GREEN}✓${RESET} Obsidian"
else
echo -e " ${ORANGE}✗${RESET} Obsidian — run: brew install --cask obsidian"
Expand Down Expand Up @@ -458,4 +465,4 @@ echo -e " timestamped backups of CLAUDE.md, and only adds what is missing.${RES
echo ""

# Open Obsidian
open -a Obsidian "$VAULT_PATH" 2>/dev/null || open -a Obsidian 2>/dev/null || true
open -a Obsidian "$VAULT_PATH" 2>/dev/null || open -a Obsidian 2>/dev/null || true