Closed
Conversation
Default to 3 attempts
chuckwondo
requested changes
May 23, 2025
Contributor
chuckwondo
left a comment
chuckwondo
left a comment
There was a problem hiding this comment.
@trey-stafford, thanks for picking this up. We can avoid manually implementing retry logic by making use of existing implementations. See #996 (comment)
This reverts commit 59a3c16.
trey-stafford
added a commit
that referenced
this pull request
May 23, 2025
trey-stafford
force-pushed
the
retry-downloads
branch
from
c6e0ecf to
f7548ca
Compare
trey-stafford
commented
May 23, 2025
| self._clone_session_in_local_thread(original_session) | ||
| session = self.thread_locals.local_thread_session | ||
| retries = Retry(total=retries) | ||
| session.mount("https://", HTTPAdapter(max_retries=retries)) |
Contributor
Author
There was a problem hiding this comment.
I suspect this is better suited for the code that initializes the session object earthaccess uses, but I'll look into that more closely later.
Contributor
There was a problem hiding this comment.
Yes, this is not the place where you want to add this functionality.
Contributor
|
Closing in favor of #1074 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #600
Pull Request (PR) draft checklist - click to expand
contributing documentation
before getting started.
title such as "Add testing details to the contributor section of the README".
Example PRs: #763
example
closes #1. SeeGitHub docs - Linking a pull request to an issue.
CHANGELOG.mdwith details about your change in a section titled## Unreleased. If such a section does not exist, please create one. FollowCommon Changelog for your additions.
Example PRs: #763
README.mdwith details of changes to theearthaccess interface, if any. Consider new environment variables, function names,
decorators, etc.
Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!
Pull Request (PR) merge checklist - click to expand
Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the
@nsidc/earthaccess-supportteam in a comment and wewill help you out!
Request containing "pre-commit.ci autofix" to automate this.
📚 Documentation preview 📚: https://earthaccess--1016.org.readthedocs.build/en/1016/