Skip to content

Add FutureWarning to DataCollections and DataGranules methods decorated with @property#1267

Merged
andypbarrett merged 21 commits intomainfrom
add_future_warning
Mar 31, 2026
Merged

Add FutureWarning to DataCollections and DataGranules methods decorated with @property#1267
andypbarrett merged 21 commits intomainfrom
add_future_warning

Conversation

@andypbarrett
Copy link
Copy Markdown
Contributor

@andypbarrett andypbarrett commented Mar 23, 2026

Description

This PR add FutureWarnings to DataCollections and DataGranules methods that have been "decorated" with @property in #1187. This is in preparation for release of version 1.0 to which #1187 will add breaking changes. This resolves #1266

"Ready for review" checklist

  • Open PR as draft
  • Please review our Pull Request Guide
  • Mark "ready for review" after following instructions in the guide

Merge checklist

  • PR title is descriptive
  • PR body contains links to related and resolved issues (e.g. closes #1)
  • If needed, CHANGELOG.md updated
  • If needed, docs and/or README.md updated
  • If needed, unit tests added
  • All checks passing (comment pre-commit.ci autofix if pre-commit is failing)
  • At least one approval

📚 Documentation preview 📚: https://earthaccess--1267.org.readthedocs.build/en/1267/

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

Binder 👈 Launch a binder notebook on this branch for commit e61601f

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit e9390f2

Binder 👈 Launch a binder notebook on this branch for commit 92a2fc4

Binder 👈 Launch a binder notebook on this branch for commit d37f5ec

Binder 👈 Launch a binder notebook on this branch for commit 034f8d2

Binder 👈 Launch a binder notebook on this branch for commit 8efbf29

Binder 👈 Launch a binder notebook on this branch for commit b57aab8

@andypbarrett andypbarrett marked this pull request as ready for review March 31, 2026 18:20
Copy link
Copy Markdown
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful 🤩

@andypbarrett andypbarrett merged commit 195051f into main Mar 31, 2026
12 checks passed
@andypbarrett andypbarrett deleted the add_future_warning branch March 31, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add FutureWarning to announce changes to search_datasets and search_data methods behavior

3 participants