Conversation
288af58 to
ba04d27
Compare
ba04d27 to
dd7f16d
Compare
|
@guillaume-sainthillier Thank your for opening the PR. However the PR is quite large and some of the changes are... quite drastic. Why change the CI pipeline? And an minor update pr with about 4k lines removed :)? Maybe we can shrink the PR and split it into more PRs which are easier to review. Could you open a discussion in this repository for the CI-Pipeline changes? What are the benefits and so. :) |
Thanks @guillaume-sainthillier. That's much better to understand. We'll continue the discussion in the remaining PRs. The PR with the PHPStan modifications is already merged. Thank you :) |
|
@guillaume-sainthillier Thank you for your work on this. Several updates to the library have made this PR outdated and likely unnecessary now. Thanks again for your contribution. |
improve code quality and CI workflows