Skip to content

Minor update#64

Closed
guillaume-sainthillier wants to merge 10 commits intoeasybill:masterfrom
silarhi:update
Closed

Minor update#64
guillaume-sainthillier wants to merge 10 commits intoeasybill:masterfrom
silarhi:update

Conversation

@guillaume-sainthillier
Copy link
Contributor

improve code quality and CI workflows

@guillaume-sainthillier guillaume-sainthillier force-pushed the update branch 3 times, most recently from 288af58 to ba04d27 Compare September 28, 2024 12:01
@BolZer
Copy link
Member

BolZer commented Oct 19, 2024

@guillaume-sainthillier Thank your for opening the PR. However the PR is quite large and some of the changes are... quite drastic. Why change the CI pipeline? And an minor update pr with about 4k lines removed :)? Maybe we can shrink the PR and split it into more PRs which are easier to review. Could you open a discussion in this repository for the CI-Pipeline changes? What are the benefits and so. :)

@guillaume-sainthillier
Copy link
Contributor Author

guillaume-sainthillier commented Oct 21, 2024

Hello @BolZer, i've split this PR into 2 more by adding #65 and #66.
Will rebase this branch once you decide to merge them (or not).

Thanks,
Guillaume

@BolZer
Copy link
Member

BolZer commented Oct 25, 2024

Hello @BolZer, i've split this PR into 2 more by adding #65 and #66. Will rebase this branch once you decide to merge them (or not).

Thanks, Guillaume

Thanks @guillaume-sainthillier. That's much better to understand. We'll continue the discussion in the remaining PRs. The PR with the PHPStan modifications is already merged. Thank you :)

@BolZer
Copy link
Member

BolZer commented Oct 14, 2025

@guillaume-sainthillier Thank you for your work on this. Several updates to the library have made this PR outdated and likely unnecessary now. Thanks again for your contribution.

@BolZer BolZer closed this Oct 14, 2025
@guillaume-sainthillier
Copy link
Contributor Author

@BolZer okay no pb, what about the #66 ? Still actual to test on minor and major package versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants