fix: centralize AllowCommentIgnores, expand groups in except, add def…#205
Merged
2 commits merged intomainfrom Feb 23, 2026
Merged
fix: centralize AllowCommentIgnores, expand groups in except, add def…#2052 commits merged intomainfrom
2 commits merged intomainfrom
Conversation
Contributor
ZergsLaw
commented
Feb 22, 2026
ZergsLaw
commented
- Move SetAllowCommentIgnores into buildCore() so it applies to all commands (lint, breaking, generate, mod)
- Expand group names (MINIMAL, BASIC, DEFAULT, COMMENTS, UNARY_RPC) in lint.except
- Default enum_zero_value_suffix to UNSPECIFIED, service_suffix to Service
- Add proper schema validation for breaking section (ignore, against_git_ref)
- Validate generated config in init command before writing to disk
- Update documentation to reflect all changes
- Add tests for except group expansion, default suffixes, breaking schema validation
…ault suffixes, validate breaking schema and init config - Move SetAllowCommentIgnores into buildCore() so it applies to all commands (lint, breaking, generate, mod) - Expand group names (MINIMAL, BASIC, DEFAULT, COMMENTS, UNARY_RPC) in lint.except - Default enum_zero_value_suffix to UNSPECIFIED, service_suffix to Service - Add proper schema validation for breaking section (ignore, against_git_ref) - Validate generated config in init command before writing to disk - Update documentation to reflect all changes - Add tests for except group expansion, default suffixes, breaking schema validation
hound672
previously approved these changes
Feb 22, 2026
ghost
previously approved these changes
Feb 22, 2026
ghost
dismissed stale reviews from
ghost
approved these changes
Feb 23, 2026
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.