feat: migrate options package to mcp/options/v1 and add typed field c…#1
Merged
feat: migrate options package to mcp/options/v1 and add typed field c…#1
Conversation
…onstraints - Move options.proto from api/mcp/options/v1 to mcp/options/v1 - Add typed ExampleValue/ExampleObject/ExampleArray proto messages - Add FieldOptions: examples, default_value, string/number/array constraints - Add MessageOptions (title, description, examples) - Add EnumOptions (title, description) and EnumValueOptions (description, hidden) - Propagate standard protobuf deprecated option from MethodOptions - Remove dead hidden/disabled/required/optional fields from MethodOptions/FieldOptions - Update schema builder to apply string, number, and array constraints - Update codegen to materialize typed examples and defaults - Add property-based tests for round-trip, constraints, message/enum options - Update example proto, generated code, golden snapshot, and all tests - Update easyp.yaml and AGENTS.md to reflect new package path
ZergsLaw
commented
Mar 17, 2026
|
|
||
| // format defines a built-in JSON Schema format (e.g., "email", "uri", "uuid", "date-time", "ipv4", "hostname"). | ||
| // See: https://json-schema.org/understanding-json-schema/reference/string.html#format | ||
| string format = 11; |
Contributor
Author
There was a problem hiding this comment.
Кстати, может стоит заменить format на энум, надо подумать будет
ZergsLaw
commented
Mar 17, 2026
| // - Null: { null_value: true } | ||
| // - Object: { object_value: { properties: { "key": { string_value: "val" } } } } | ||
| // - Array: { array_value: { items: [{ number_value: 1 }, { number_value: 2 }] } } | ||
| message ExampleValue { |
Contributor
Author
There was a problem hiding this comment.
Самая важная деталь, я вот думаю может отказаться от единичного элемента и оставить только массив
Yakwilik
approved these changes
Mar 17, 2026
…onstraints - Move options.proto from api/mcp/options/v1 to mcp/options/v1 - Add typed ExampleValue/ExampleObject/ExampleArray proto messages - Add FieldOptions: examples, default_value, string/number/array constraints - Add MessageOptions (title, description, examples) - Add EnumOptions (title, description) and EnumValueOptions (description, hidden) - Propagate standard protobuf deprecated option from MethodOptions - Remove dead hidden/disabled/required/optional fields from MethodOptions/FieldOptions - Update schema builder to apply string, number, and array constraints - Update codegen to materialize typed examples and defaults - Add property-based tests for round-trip, constraints, message/enum options - Update example proto, generated code, golden snapshot, and all tests - Update easyp.yaml and AGENTS.md to reflect new package path
…onstraints - Move options.proto from api/mcp/options/v1 to mcp/options/v1 - Add typed ExampleValue/ExampleObject/ExampleArray proto messages - Add FieldOptions: examples, default_value, string/number/array constraints - Add MessageOptions (title, description, examples) - Add EnumOptions (title, description) and EnumValueOptions (description, hidden) - Propagate standard protobuf deprecated option from MethodOptions - Remove dead hidden/disabled/required/optional fields from MethodOptions/FieldOptions - Update schema builder to apply string, number, and array constraints - Update codegen to materialize typed examples and defaults - Add property-based tests for round-trip, constraints, message/enum options - Update example proto, generated code, golden snapshot, and all tests - Update easyp.yaml and AGENTS.md to reflect new package path
ZergsLaw
added a commit
that referenced
this pull request
Mar 29, 2026
#1) * feat: migrate options package to mcp/options/v1 and add typed field constraints - Move options.proto from api/mcp/options/v1 to mcp/options/v1 - Add typed ExampleValue/ExampleObject/ExampleArray proto messages - Add FieldOptions: examples, default_value, string/number/array constraints - Add MessageOptions (title, description, examples) - Add EnumOptions (title, description) and EnumValueOptions (description, hidden) - Propagate standard protobuf deprecated option from MethodOptions - Remove dead hidden/disabled/required/optional fields from MethodOptions/FieldOptions - Update schema builder to apply string, number, and array constraints - Update codegen to materialize typed examples and defaults - Add property-based tests for round-trip, constraints, message/enum options - Update example proto, generated code, golden snapshot, and all tests - Update easyp.yaml and AGENTS.md to reflect new package path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…onstraints