Added desired units and tests #188
Open
+177
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #188 +/- ##
========================================
Coverage 81.15% 81.16%
========================================
Files 52 52
Lines 4267 4279 +12
Branches 740 742 +2
========================================
+ Hits 3463 3473 +10
- Misses 624 625 +1
- Partials 180 181 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rozyczko
reviewed
Jan 9, 2026
| try: | ||
| self._convert_unit(self._desired_unit) | ||
| except Exception as e: | ||
| raise UnitError(f'Failed to convert unit from {temporary_parameter.unit} to {self._desired_unit}: {e}') |
Member
There was a problem hiding this comment.
Should we completely bail out on bad unit conversion? Maybe return the original value with the original unit and warn users of the failure of the unit conversion.
Member
Author
There was a problem hiding this comment.
Hmm, good question. I tend to think yes, since something must have gone wrong if the user expects a unit that is incompatible with the calculated unit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added desired units for the dependent parameter constructors, and a method to change it later:
set_desired_unit