Merged
Conversation
felipeshiwu
commented
Jan 14, 2026
| } | ||
|
|
||
| @unlink($filename);//if the zip already exists, overwrite it | ||
| if ( file_exists( $filename ) ) { |
Author
There was a problem hiding this comment.
as reference, code from original repo
https://github.com/mk-j/PHP_XLSXWriter/blob/master/xlsxwriter.class.php#L93
felipeshiwu
force-pushed
the
upkeep/check-file-exists-before-unlink
branch
from
b190556 to
a1f85ac
Compare
daltones
reviewed
Jan 14, 2026
Comment on lines
+75
to
+76
| self::log( "Error in " . __CLASS__ . "::" . __FUNCTION__ . ", file is not writeable." ); | ||
| return; |
There was a problem hiding this comment.
I know you're just following a pattern here. But in our standards, this should definitely be an exception.
daltones
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.