Change AlphaFoldPayload variable name and update type.#326
Merged
Conversation
✅ Deploy Preview for cozy-marzipan-abb3b4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Swaathik
requested changes
Oct 14, 2025
| export type PredictionData = { | ||
| export type AlphaFoldPayload = Array<{ | ||
| entryId: string; | ||
| modelEntityId?: string; |
Collaborator
There was a problem hiding this comment.
EntryId is deprecated and renamed to modelEntityId in the recent AlphaFold update. Shall we replace the few occurrences of entryId with modelEntityId as we need to do it at some point anyway?
Contributor
Author
There was a problem hiding this comment.
Good point - updated
| export type PredictionData = { | ||
| export type AlphaFoldPayload = Array<{ | ||
| entryId: string; | ||
| modelEntityId?: string; |
Collaborator
There was a problem hiding this comment.
Suggested change
| modelEntityId?: string; | |
| modelEntityId: string; |
Comment on lines
+86
to
+90
| uniprotSequence?: string; | ||
| uniprotStart?: number; | ||
| uniprotEnd?: number; | ||
| isReferenceProteome?: boolean; | ||
| isReviewed?: boolean; |
Collaborator
There was a problem hiding this comment.
Also, these ones are deprecated and the new fields are included. Safe to remove these too as they are only part of the schema and not used anywhere else
Swaathik
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.