Add apiSupported property#30
Open
FluorescentHallucinogen wants to merge 1 commit intoebidel:masterfrom
Open
Conversation
* Add `apiSupported` property that indicates whether Geolocation API is supported or not. * Update code and descriptions of samples in `geo-location.html`, `demo/index.html` and `README.md` files. * Remove `version` field in `bower.json` file, because it's deprecated and ignored by Bower (https://github.com/bower/spec/blob/master/json.md#version). * Add `polymer-element`, `polymer-2` and `polymer-2-hybrid` keywords to `bower.json` file to indicate that this is Polymer 1.x/2.x hybrid element.
Contributor
Author
|
@ebidel PTAL. |
ebidel
reviewed
Aug 29, 2017
| properties: { | ||
| /** | ||
| * Indicates whether `Geolocation API` is supported or not. | ||
| */ |
Contributor
Author
There was a problem hiding this comment.
@ebidel IMO, api-supported is more clear than just supported. Many web components use api-supported, e.g.:
Owner
|
Please add a test. |
Contributor
Author
What do you mean? |
Owner
|
Add a test case: https://github.com/ebidel/geo-location/tree/master/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apiSupportedproperty that indicates whether Geolocation API is supported or not.geo-location.html,demo/index.htmlandREADME.mdfiles.versionfield inbower.jsonfile, because it's deprecated and ignored by Bower (https://github.com/bower/spec/blob/master/json.md#version).polymer-element,polymer-2andpolymer-2-hybridkeywords tobower.jsonfile to indicate that this is Polymer 1.x/2.x hybrid element.