Skip to content

Make message pop up in chat for a proximity of players#10

Open
JamieGrimwood wants to merge 1 commit intoeblio:masterfrom
JamieGrimwood:master
Open

Make message pop up in chat for a proximity of players#10
JamieGrimwood wants to merge 1 commit intoeblio:masterfrom
JamieGrimwood:master

Conversation

@JamieGrimwood
Copy link

This makes the /me pop up in chat for a proximity of players. Tested and works fine.

@JamieGrimwood
Copy link
Author

Wait before merging this, other players can't see the text but you can. Will make a fix now.

@eblio
Copy link
Owner

eblio commented Dec 13, 2021

Hi, thanks for the pull request, can you make it as an option in the config file ?

As the code is rightnow it migth need some changes before being merged but I'll wait for you to finish your pull request before elaborating too much.

@JamieGrimwood
Copy link
Author

JamieGrimwood commented Dec 18, 2021

Yeah I can do that, the only issue I have right now is that it only shows the player who executed the /me. I need to fix this and will tomorrow when I get to my computer.

@eblio
Copy link
Owner

eblio commented Dec 21, 2021

Yeah, you don't need to loop over every player in order to display the message. You only need to display the message in the chat when the function onShareDisplay is called and that the distance is close enough.

@JamieGrimwood
Copy link
Author

Alright, if you could help fix it that would be great. I am very very new to lua however I thought this might work.

@eblio
Copy link
Owner

eblio commented Dec 28, 2021

I haven't launched FiveM in a while. Will probably do it in a week or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments