Alligning output variables between code and settings file#213
Open
ecCinziaMazzetti wants to merge 1 commit intodevelopmentfrom
Open
Alligning output variables between code and settings file#213ecCinziaMazzetti wants to merge 1 commit intodevelopmentfrom
ecCinziaMazzetti wants to merge 1 commit intodevelopmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm reviewing the lisfloodSettings_reference.xml ahead of the LongTermRun and operationalisation. I found a few inconsistencies between lisfloodSettings_reference.xml and default_options.py. I tried to put some order.
The only important change is the name of the file used to store ReservoirFillState, because it was not matching with the name used for initialisation.
ReservoirFillState -> file name changed to rsfil (which is the name used for the end file and the initialisation)
EWater and PolderLevelEnd -> already available in the py file, added to the xml file
LakeStorageM3 -> duplicated in the xml file, keeping the one using output file LakeStor
WaterUseMaps -> not available in py code, removed from xml
UZOutflowOtherMaps , variable UZOutflow[0] -> available in py, added to xml
CumIntSealedMaps -> output file renamed to 'cseal' for concistency with State and End file
PrefFlowOtherMaps -> available in py, added to xml as pflowO
PrefFlowIrrigationMaps -> available in py, added to xml as pflowi
NumDaysSpinUp -> duplicated in xml file
repETactBudykoTs -> added to xml
added repOverlandFlowMaps to py
OFDirectMaps added to repOverlandFlowMaps
OFForestMaps added to repOverlandFlowMaps
OFOtherMaps added to repOverlandFlowMaps
TransLossMaps -> added TransLoss to restrictions in py
some refactoring to the initial part of the xml file because it was using a slightly different format
https://jira.smhi.tds.tieto.com/browse/EFCC-4755