Fix proto_024 ManagerMetadata missing ManagerOperationMetadata methods#14
Merged
jevonearth merged 1 commit intov2from Mar 3, 2026
Merged
Conversation
…ethods proto_024_PtTALLiN.ManagerMetadata was defined as a new struct (needed because it uses proto_024's own InternalOperationResult type) but was missing GetResult() and GetInternalOperationResults(). Without these, *ManagerMetadata[T] does not satisfy core.ManagerOperationMetadata, so collectMilligasAndStorage silently returns (0, 0) and teztool.Fill sets gas_limit=0 and storage_limit=0 on all operations. Add the missing methods and a compile-time interface satisfaction check to prevent this class of regression. Verified against live PtTALLiNt shadownet run_operation response: consumed_milligas now correctly extracted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proto_024_PtTALLiN.ManagerMetadatawas defined as a new struct (can't alias proto_023's because it uses proto_024's ownInternalOperationResultwithAddressRegistryDiff) but was missingGetResult()andGetInternalOperationResults()*ManagerMetadata[T]doesn't satisfycore.ManagerOperationMetadata, socollectMilligasAndStoragesilently returns(0, 0)andteztool.Fillsetsgas_limit=0/storage_limit=0on all operationsvar _) to prevent this class of regressionVerification
Decoded an actual
run_operationbinary response from PtTALLiNt shadownet (https://shadownet.tezos.ecadinfra.com). Confirmed variant tag is0x00(with metadata, not variant 1 as initially suspected), andconsumed_milligas = 2168755is now correctly extracted.Test plan
go build ./...passesgo test ./...passesGetResult())run_operationresponse extractsconsumed_milligascorrectly