fix: allow ballot sub-kinds (yay/nay/pass) in operation kind validation#755
Merged
jevonearth merged 1 commit intoecadlabs:mainfrom Mar 3, 2026
Merged
Conversation
- Fixes operation kind validation to allow ballot:yay, ballot:nay, and ballot:pass in allow.generic config - These are valid signatory-specific sub-kind values for granular ballot policy control - Validation splits on ':', validates base operation, and strictly validates ballot suffixes - Sub-kind syntax on non-ballot operations is rejected - Added 5 new test cases to TestOperationKindCheck
e-asphyx
approved these changes
Feb 23, 2026
Contributor
|
Thank you for the contribution @vch9 ! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, while debugging ecadlabs/gotez#13 I noticed this regression between 1.3.0 and 1.3.1. I used git bisect and it came down to #657.
Note
Low Risk
Small, localized change to configuration validation plus tests; low risk aside from potentially changing behavior for configs that previously (incorrectly) used
:in operation kinds.Overview
Fixes policy validation to accept ballot sub-kinds in
allow.genericusingballot:yay,ballot:nay, andballot:passsyntax, while still rejectingkind:subkindfor non-ballot operations and invalid ballot values.Adds unit tests for the new ballot sub-kind validation, including negative cases for invalid sub-kinds and unsupported
op:subformats.Written by Cursor Bugbot for commit ecbdc35. This will update automatically on new commits. Configure here.