reducing the "scope" of new_sorted_actual_scores#20
Open
jacobvosmaer wants to merge 1 commit intoechonest:masterfrom
Open
reducing the "scope" of new_sorted_actual_scores#20jacobvosmaer wants to merge 1 commit intoechonest:masterfrom
jacobvosmaer wants to merge 1 commit intoechonest:masterfrom
Conversation
Contributor
|
Thanks. You're right that the calculation of |
Contributor
|
Manually applied, committed and merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have refactored the calculation of
sorted_actual_scoresinbest_match_for_query(). The assignmentsorted_actual_scores = new_sorted_actual_scoreswas occurring later than necessary, making it harder to see that the sole purpose of the variablenew_sorted_actual_scoresis as a temporary variable for the removal of duplicates.Would you agree that this improves the readability of the code?