Fixed Update-FB-Type quickfix to include SubAppTypes

[sebHollersbacher]

No description provided.

[github-actions]

Test Results

  110 files  ±0    110 suites  ±0   1m 11s ⏱️ -1s
6 107 tests  - 1  6 107 ✅  - 1  0 💤 ±0  0 ❌ ±0 
6 108 runs   - 1  6 108 ✅  - 1  0 💤 ±0  0 ❌ ±0 

Results for commit 5772311. ± Comparison against base commit c01798d.

This pull request removes 30 and adds 11 tests. Note that renamed tests count towards both.

 
  *
  Multi-line comment
 Multi-line comment
 comment *)->
 comment */->
(*
*)
*/
…

org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 10: (*
 Multi-line comment
*)
s := "Hello   World!";
->s:="Hello   World!";
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 11: /*
 Multi-line comment
*/
s := "Hello   World!";
->s:="Hello   World!";
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 15: whitespace at the end 
->whitespace at the end
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 22: test unclosed multine comment
(*
  Multi-line comment
  *
->test unclosed multine comment
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 23: test unclosed multine comment
(*
  Multi-line comment

->test unclosed multine comment
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 24: test unclosed multine comment
/*
  Multi-line comment
  *
->test unclosed multine comment
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 25: test unclosed multine comment
/*
  Multi-line comment

->test unclosed multine comment
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 5: (* This is a multi-line 
 
 comment *)->
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 6: /* This is a multi-line 
 
 comment */->
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 8: // This is a single-line  
test->test
…

♻️ This comment has been updated with latest results.

[mx990]

This will also allow to select SubApps and Function FBs for internal FBs. I believe we have to restrict the selection as follows:

• allow only FB types for Base FB types,
• allow only FB and FC types for Composite FB types,
• allow all FB, FC, and SubApp types for SubApp types and systems.

I would suggest to use TypeEntry.getTypeEClass() to determine the class of the type for each marker and show an error when an incompatible type is selected.

[sebHollersbacher]

Thank you for pointing that out.
However, I'm not sure how to get the marker class using TypeEntry.getTypeEClass.
I would have gotten the markers TypeEntry over the Resource and TypeLibrary

[mx990]

Yes, I would have gotten it that way, as well.

[mx990]

Please add a null check/filter for the result of getTypeEntry(file) in case the file has been deleted in the meantime. Please also use TypeEntry.getTypeEClass() instead of getType() to avoid potentially loading the type unnecessaily. I would also suggest to cache the list of EClasses in prepare to avoid re-retrieving them on each selection change.