fix: pixelScaling and SetPositionCommandTest

[Kappuccino111]

Fixes #1969.

Opening again on the develop branch. Migrated from #1984

[Kappuccino111]

@azoitl should be good to go now.

Regarding the tests, it would take me some more time to go through the PR #1985 and #1986.

But for now the all tests should pass and build.

Do I open a discussion about which aspects of the tests we need to improve: for example test.model, test.ui etc ?

[Kappuccino111]

Hi @azoitl, please let me know if any changes are needed. Otherwise, I believe this is ready to merge and we can close the issue.

I know how busy maintainers can be, so I really appreciate you taking the time to review this simple change ✌️

[azoitl]

@Kappuccino111 please excuse my late response. Many thx for transferring this to develop.

Regarding the required test changes: The main required change is that the SetPositionCommand is not accepting move deltas in screen coordinates anymore but only in 1499 coordinate space. The only test that needs to be adapted is the org.eclipse.fordiac.ide.model.commands.change.SetPositionCommandTest.

Feel free to open a discussion or issue for further discussing potential changes and improvements to this test.

[github-actions]

Test Results

  110 files  ±0    110 suites  ±0   1m 11s ⏱️ ±0s
6 108 tests ±0  6 108 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 109 runs  ±0  6 109 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4ee1bcc. ± Comparison against base commit a606077.

This pull request removes 29 and adds 11 tests. Note that renamed tests count towards both.

 
  *
  Multi-line comment
 Multi-line comment
 comment *)->
 comment */->
(*
*)
*/
…

org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 10: (*
 Multi-line comment
*)
s := "Hello   World!";
->s:="Hello   World!";
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 11: /*
 Multi-line comment
*/
s := "Hello   World!";
->s:="Hello   World!";
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 15: whitespace at the end 
->whitespace at the end
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 22: test unclosed multine comment
(*
  Multi-line comment
  *
->test unclosed multine comment
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 23: test unclosed multine comment
(*
  Multi-line comment

->test unclosed multine comment
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 24: test unclosed multine comment
/*
  Multi-line comment
  *
->test unclosed multine comment
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 25: test unclosed multine comment
/*
  Multi-line comment

->test unclosed multine comment
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 5: (* This is a multi-line 
 
 comment *)->
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 6: /* This is a multi-line 
 
 comment */->
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 8: // This is a single-line  
test->test
…

[azoitl]

I did a quick test and couldn't see an impact on coordinates in existing files.