Fix issues in OCL checks #1850

[azoitl]

• fix warnings about double quotes
• repair subapp-invariants for TypedSubApps and UntypedSubapps

Fixes: #1850

[github-actions]

Test Results

  110 files  ±0    110 suites  ±0   1m 9s ⏱️ -1s
6 106 tests ±0  6 106 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 107 runs  ±0  6 107 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d98b2c1. ± Comparison against base commit c387184.

This pull request removes 29 and adds 11 tests. Note that renamed tests count towards both.

 
  *
  Multi-line comment
 Multi-line comment
 comment *)->
 comment */->
(*
*)
*/
…

org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 10: (*
 Multi-line comment
*)
s := "Hello   World!";
->s:="Hello   World!";
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 11: /*
 Multi-line comment
*/
s := "Hello   World!";
->s:="Hello   World!";
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 15: whitespace at the end 
->whitespace at the end
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 22: test unclosed multine comment
(*
  Multi-line comment
  *
->test unclosed multine comment
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 23: test unclosed multine comment
(*
  Multi-line comment

->test unclosed multine comment
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 24: test unclosed multine comment
/*
  Multi-line comment
  *
->test unclosed multine comment
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 25: test unclosed multine comment
/*
  Multi-line comment

->test unclosed multine comment
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 5: (* This is a multi-line 
 
 comment *)->
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 6: /* This is a multi-line 
 
 comment */->
org.eclipse.fordiac.ide.test.model.util.StringTransformTest ‑ transformStringName(String, String) 8: // This is a single-line  
test->test
…

[mx990]

Suggested change

	inv _'WARNING;[DeadState]" : not self.isStartState() implies (self->closure(inTransitions.source)->select(state : ECState | state.isStartState())->size() > 0)
	inv _'WARNING;[DeadState]' : not self.isStartState() implies (self->closure(inTransitions.source)->select(state : ECState | state.isStartState())->size() > 0)

[mx990]

Does it actually make sense to have these warnings at instances of typed subapps?

[ernstblechaPT]

As far as I can tell: currently the options are to

• have it detected for the instances or
• not have the warning at all as the OCL checks are performed based on the application

Moving this check to the types would require an additional set of OCL-rules that are applied based on the Type Library. Those rules would then apply to all types in the Type Library and not just the ones that are acutally in use; Maybe the people that developed the code-smell-concept (e.g. @LisaSonnleithner) can help here to clarify?