Backport: Remove test data with too long log configs, const specifier fix and bluechi-is-enabled test fix #1111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test cases for too long log configs (level, target and isquiet) causes the bluechi-agent service to fail (as expected). However, this happens in the test setup phase where we expect a running agent. Due to timing issues this check might even pass, depending how fast the status is being checked. This causes the test to be flacky. Since such a long input for log configs is unrealistic and the proper level for testing is on the unit level (test without the long data is already in place), these cases have een removed. In addition, the unused BluechiConfig variable for max line length has been removed. Signed-off-by: Michael Engel <mengel@redhat.com>
Since systemd 253, systemctl returns error code 4 when the is-enabled command is applied to non-existent unit. This differs from bluechictl is-enabled since here the error code for the sd_bus_call_method is returned. Signed-off-by: Michael Engel <mengel@redhat.com>
Signed-off-by: Michael Engel <mengel@redhat.com>
engelmi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of these commits: